consider replacing rsync with cp and tar in CMakeLists.txt#558
Open
izzint wants to merge 6 commits intosmartcmd:mainfrom
Open
consider replacing rsync with cp and tar in CMakeLists.txt#558izzint wants to merge 6 commits intosmartcmd:mainfrom
izzint wants to merge 6 commits intosmartcmd:mainfrom
Conversation
Author
|
Added a function to insure the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solution is a little more unruly compared to using just
rsync, but has more general support on most *nix systems (you don't need to install any additional packages to use this at all, cp and tar are pretty well included unix tools)My main gripe with using
rsyncis that when it does come pre-included on an operating system, it's usually quite an old version, and that usually means its a whole lot slower. The version included on macOS (2.6.9) is about 19 years old at this point, and takes a whole 10 seconds to copy every folder over, modernrsyncis way better at this task and it brings that down to about 4 seconds1, albeit you need to install it viabrewand add it to PATH.The method involving
tarandcpon the other hand takes about 2.5 seconds to fully complete, as well as being generally more compatible. ;]Footnotes
tested on macos 15.7.3 with rsync 3.4.1 from brew ↩