Fix crash when FOV is equal to zero#669
Open
qwasdrizzel wants to merge 6 commits intosmartcmd:mainfrom
Open
Conversation
Removed checks that limit flying to a 90 degree angle, which caused the problem.
Contributor
|
when would this crash ever realistically happen |
Collaborator
|
Shouldn't you just set FOV to 1 instead of 0.01 here? Seems like a random value to force at FOV 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a crash when FOV is equal to zero.
Changes
Added a if statement inside of
GameRenderer::getFovto check ifm_fovis less than 1. If the FOV is less than one it sets it to 0.01.Previous Behavior
Crashed when FOV was equal to zero.
Root Cause
DirectX caused it with the expression
!XMScalarNearEqual(FovAngleY, 0.0f, 0.00001f * 2.0f)New Behavior
Limits FOV to 0.01.
Fix Implementation
If statement limiting
m_fovto 0.01 if under 1.AI Use Disclosure
No AI.