Conversation
Now located in Graphics section. Based on the FOV thing from discord idk
|
Looks good! But I think you accidentally left some temporary changes in |
|
Good PR! |
|
Make sure all assets are updated outside of the asset bundles (like in Common/Media and the platform folders) and then (assuming this tests well) we'll merge this in! |
|
just added the swf files on media folder |
@MijaeLio Could you undo these changes? I don't see what relevance they have to this PR |
codeHusky
left a comment
There was a problem hiding this comment.
"Temporary" changes should be rolled back before this can be merged
|
Awesome. What can we also improve at this point? Or I can merge already? |
|
Good PR, could we have an option to revert settings to their default? |
The only bug I found and that I would need help on fixing it is that when you change the render distance from the main menu before playing a world the game will still use the normal render distance, until you change the render distance again. I don't know why it happens and I need help on finding that out. It's just a bug that happens when you first start playing. I didn't find any other bugs besides that. |
|
Also sorry for taking long on reverting files lol. I was asleep |
|
Id fix that main menu settings bug before we merge this. That’s a major consistency issue |
|
fixed |
| } | ||
| } | ||
| #endif | ||
|
|
There was a problem hiding this comment.
what's the purpose of this locale code change
There was a problem hiding this comment.
For now nothing really, I can remove that. But I had in mind to write support for a language option since languages only work on XBOX and the actual function doesn't work on windows 64, this makes the game actually get the languages for it
There was a problem hiding this comment.
Please remove that and do that in a dedicated pr
|
Nice job, looks like you got farther then me |
Fixed visual bug and made the chunk updates depend to your view distance.
* FOV option without debug menu Now located in Graphics section. Based on the FOV thing from discord idk * language * render distance option for graphics menu * oop * swf files on media * revert changes on language selector * nvm it was actually easy to fix * forgot this * Final probably Fixed visual bug and made the chunk updates depend to your view distance.
* FOV option without debug menu Now located in Graphics section. Based on the FOV thing from discord idk * language * render distance option for graphics menu * oop * swf files on media * revert changes on language selector * nvm it was actually easy to fix * forgot this * Final probably Fixed visual bug and made the chunk updates depend to your view distance.
* FOV option without debug menu Now located in Graphics section. Based on the FOV thing from discord idk * language * render distance option for graphics menu * oop * swf files on media * revert changes on language selector * nvm it was actually easy to fix * forgot this * Final probably Fixed visual bug and made the chunk updates depend to your view distance.








real.mp4
Description
Changes
SWF files for SettingsGraphicsMenu on every resolution, also fixing missing FOV option in those files.
GameRenderer.cpp
UIScene_SettingsGraphicsMenu.cpp
UIScene_SettingsGraphicsMenu.h
Consoles_app.cpp
App_enums.h
MediaWindows64.arc
Previous Behavior
There wasn't a way to change your render distance before. There is mentions for an option called "viewDistance" in GameRenderer.cpp. But it only uses 0 (16 Render Distance) with no way to change it normally.
Root Cause
No option for this was added on any menu before, and mc->options->viewDistance was unused for anything else than just setting up the game to use 16 chunks render distance only.
New Behavior
Make mc->options->viewDistance actually useful with adding a slider for it on Graphics Menu
Fix Implementation
I added two tables for UIScene_SettingsGraphicsMenu.cpp. LevelToDistance and DistanceToLevel to convert between slide values and chunks distances (I actually could do it without using those but it would look ugly for the slider to get 3 - 2 - 1.. values instead of 2 - 4 - 8.. values)
Updated renderDistance on GameRenderer.cpp so the game doesn't glitch when going more than 32 chunks (viewDistance 0)
As said before, updated SWF files to add this option and fix the missing FOV slider for 720 and 480
AI Use Disclosure
No AI was used. This took me the entire day and was a complete journey even if the changes are small 😭
Related Issues