Skip to content

Sound Fixes#686

Merged
codeHusky merged 10 commits intosmartcmd:mainfrom
GuglioIsStupid:UISoundsFix
Mar 7, 2026
Merged

Sound Fixes#686
codeHusky merged 10 commits intosmartcmd:mainfrom
GuglioIsStupid:UISoundsFix

Conversation

@GuglioIsStupid
Copy link
Contributor

@GuglioIsStupid GuglioIsStupid commented Mar 6, 2026

Description

A lot of sounds were in the incorrect directories and had the wrong file names. Some were outright not in the files

This PR fixes all of those sounds and organizes them better than to how it was originally

Changes

Previous Behavior

Many sounds were missing, such as skeleton deaths, ui scrolls, and so much more, witches had no sound

New Behavior

Those sounds work again!!! and witch has sounds now!!!

AI Use Disclosure

no

Related Issues

  • Fixes an issue in the discord
2026-03-06.03-09-43.mp4

@GuglioIsStupid
Copy link
Contributor Author

HOW was there a conflict oml

@void2012
Copy link
Collaborator

void2012 commented Mar 6, 2026

IUIScene_AbstractContainerMenu also disabled press sounds if there was no item, this is not how it was like in legacy, it would play the sound whenever you clicked

Please don't. I removed that behavior in #152
I don't care about how "it was like in legacy", this was very annoying, likely a bug. Legacy shouldn't be a bar of quality itself. There was no mouse integration in the UI either in legacy, this isn't the reason we shouldn't implement that.

@GuglioIsStupid
Copy link
Contributor Author

If there's not to be a sound when you press anywhere, there should atleast still be a sound when you place an item into an empty slot, if there's no feedback in the UI it will just confuse people if they've ever actually placed the item in their inventory

@void2012
Copy link
Collaborator

void2012 commented Mar 6, 2026

Yes, but clicking with any mouse button on an empty slot should produce no sound at all.

@codeHusky
Copy link
Collaborator

Selecting empty slots with controller should still make noise like LCE, but if done with KBM it should be silent.

@codeHusky codeHusky marked this pull request as draft March 6, 2026 17:15
@GuglioIsStupid GuglioIsStupid changed the title UI sounds fix Sound Fixes Mar 6, 2026
@GuglioIsStupid
Copy link
Contributor Author

I went through and updated it, I reverted the inventory slot sound as I currently don't know where to get info of the current held item in the slot

I went through and tested every mobs sounds and all the other sounds, I have came across no issues with the sounds and even fixed other sounds that weren't implemented such as the witch and small slime

@GuglioIsStupid GuglioIsStupid marked this pull request as ready for review March 6, 2026 23:46
@codeHusky codeHusky merged commit 55be644 into smartcmd:main Mar 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants