feat: migrate TXM and AptosService config to duration types#406
Merged
feat: migrate TXM and AptosService config to duration types#406
Conversation
…ptosService config section
Replace raw integer seconds (ConfirmPollSecs, SubmitDelayDuration, TxExpirationSecs,
PruneIntervalSecs, PruneTxExpirationSecs) with config.Duration types using proper
duration strings ('2s', '4h'). Add new AptosService config section with
SubmitPollTimeout and SubmitPollInterval to decouple CRE/workflow polling from TXM
config. Remove stale TODO comments resolved by these changes.
Contributor
|
👋 Fletch153, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Fletch153
force-pushed
the
PLEX-2598/turn-constants-into-config
branch
from
de2836f to
6cf8abc
Compare
Fletch153
force-pushed
the
PLEX-2598/turn-constants-into-config
branch
from
6cf8abc to
f191bc2
Compare
product-security-plaid-production
bot
requested review from
dhaidashenko and
florian-cl
Fletch153
force-pushed
the
PLEX-2598/turn-constants-into-config
branch
from
f191bc2 to
4f25f14
Compare
Fletch153
force-pushed
the
PLEX-2598/turn-constants-into-config
branch
from
4f25f14 to
b48ecc0
Compare
Fletch153
force-pushed
the
PLEX-2598/turn-constants-into-config
branch
5 times, most recently
from
f3cfcf6 to
432b712
Compare
Add RPCConfig section with MaxConcurrentRequests and Timeout to replace hardcoded rate limiter values in chain.go. Add SimulateTx boolean to AptosServiceConfig. Add CacheTTL and CacheCleanupInterval to LogPoller config to replace hardcoded cache constants.
Fletch153
force-pushed
the
PLEX-2598/turn-constants-into-config
branch
from
432b712 to
a48783c
Compare
…stants-into-config # Conflicts: # relayer/txm/config.go
Contributor
|
LGTM! |
NewLogPoller requires a non-nil config after a48783c added configurable cache settings. Update 3 test callsites to pass DefaultConfigSet instead of nil. PLEX-2598
Fletch153
force-pushed
the
PLEX-2598/turn-constants-into-config
branch
from
776e67f to
8c21414
Compare
cawthorne
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfirmPollSecs,SubmitDelayDuration,TxExpirationSecs,PruneIntervalSecs,PruneTxExpirationSecs) withconfig.Durationtypes using proper duration strings ('2s','4h')[AptosService]TOML config section withSubmitPollTimeoutandSubmitPollIntervalto decouple CRE/workflow polling from TXM configTest plan
AptosServiceconfig section tested with custom values and defaultsAptosServiceconfig🤖 Generated with Claude Code