aptos: tolerate raw OCR transmitter accounts#1931
Closed
Conversation
📊 API Diff Results
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the capabilities registry OCR3 transmitter decoding to accept both hex-encoded accounts (including 0x/0X-prefixed forms) and raw transmitter account bytes, preventing Aptos OCR startup failures when raw bytes are emitted.
Changes:
- Add tolerant OCR3 transmitter decoding via
transmitterAccountToBytes(supports0x/0Xprefix, preserves existing unprefixed hex behavior, falls back to raw bytes). - Update
ConfigForCapabilityto use the new transmitter decoding helper. - Add unit tests covering prefixed hex decoding, invalid prefixed hex errors, and raw-byte fallback.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/loop/internal/core/services/capability/capabilities_registry.go | Introduces tolerant transmitter decoding and wires it into OCR3 config serialization. |
| pkg/loop/internal/core/services/capability/capabilities_registry_test.go | Adds unit tests for the new transmitter decoding behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pkg/loop/internal/core/services/capability/capabilities_registry.go
Outdated
Show resolved
Hide resolved
pkg/loop/internal/core/services/capability/capabilities_registry_test.go
Show resolved
Hide resolved
jmank88
previously approved these changes
Mar 26, 2026
ilija42
reviewed
Mar 26, 2026
ilija42
reviewed
Mar 26, 2026
ilija42
requested changes
Mar 26, 2026
ilija42
reviewed
Mar 26, 2026
Co-authored-by: ilija42 <57732589+ilija42@users.noreply.github.com>
ilija42
reviewed
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The merged Aptos consensus-backed read capability depends on OCR config handling during worker startup. Local CRE Aptos runs can still emit raw transmitter account bytes here, so strict hex-only decoding breaks capability startup before reads can execute.
Testing