Conversation
karen-stepanyan
force-pushed
the
DF-22944
branch
from
ea9b8c0 to
bf4f529
Compare
product-security-plaid-production
Bot
requested review from
DimitriosNaikopoulos,
chray-zhang and
vyzaldysanchez
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables support for multiple MCMS (Multi-Chain Multi-Sig) contracts on the same network within the data feeds deployment system. The changes allow different operations to specify which MCMS timelock contract to use via a qualifier.
Changes:
- Added
TimeLockQualifierfield toMCMSConfigtype to identify specific timelock contracts - Updated all changesets to pass the timelock qualifier through proposal data
- Refactored
BuildMultiChainProposalsto load MCMS state per-proposal rather than once per chain
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| deployment/data-feeds/changeset/types/types.go | Adds TimeLockQualifier field to MCMSConfig struct |
| deployment/data-feeds/changeset/proposal.go | Refactors proposal building to load MCMS state per-proposal and adds timeLockQualifier field to ProposalData |
| deployment/data-feeds/changeset/state.go | Removes unused MCMS state loading code from chain state |
| deployment/data-feeds/changeset/*.go | Updates all changeset logic functions to include timelock qualifier in proposals |
| deployment/data-feeds/changeset/*_test.go | Updates all tests to configure and pass MCMS qualifier |
| deployment/data-feeds/changeset/jd_propose_wf_jobs.go | Moves variable declaration (unrelated refactor) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
|
anirudhwarrier
approved these changes
Jan 30, 2026
alecgard
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support of multiple MCMS contracts on a single network for existing changesets
https://chainlink-core.slack.com/archives/C032JQS6HK5/p1769430791634079