Skip to content

CRE-1714: ring test real workflows#20969

Merged
mchain0 merged 25 commits intodevelopfrom
cre-1714-ring-test-real-workflows
Feb 24, 2026
Merged

CRE-1714: ring test real workflows#20969
mchain0 merged 25 commits intodevelopfrom
cre-1714-ring-test-real-workflows

Conversation

@mchain0
Copy link
Copy Markdown
Contributor

@mchain0 mchain0 commented Jan 29, 2026

PR contains:

  • fix for the smoke test to handle consensus error with missing wantShards
  • fix for the smoke test to properly initiate Arbiter state
  • refactor to integrate Store struct to be shared via reference across Ring and ShardOrchestrator (eliminates earlier broken synchronization)
  • multiple additional asserts in the smoke test for workflows, consensus round progressing, etc.
  • early version of Workflow Registry Syncer extension to call Ring, wait for the consensus and once reached - load and initiate only workflows mapped to the shard
  • several other improvements to the E2E sharding flow
  • test workflows compilation and deployment (10 workflows, cron-trigger)
  • asserting on the mappings
  • asserting on the messages for all workflows being executed in expected shards
  • rebase with the develop changes to support multiple workflow sources
  • optimization: improvement to the workflow registry syncer to communicate with local ringStore when running in shard-0
  • rebase with the develop changes to support cre package and cre.go refactor
  • allocRequests channel full handling
  • improved namings
  • scale down test improvement for flakiness
  • ValidateObservation test
  • workflow registry syncer filterWorkflowsByShard test
  • test fail early breakers added
  • beholder messages asserts replaced by chip sink asserts
  • reduced number of wfs to 5 for faster test execution

CRE-1714

@mchain0 mchain0 force-pushed the cre-1714-ring-test-real-workflows branch from 40c4976 to 4132410 Compare January 30, 2026 09:03
@github-actions
Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Jan 30, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@mchain0 mchain0 requested a review from bolekk February 19, 2026 17:37
@mchain0 mchain0 force-pushed the cre-1714-ring-test-real-workflows branch from 28c8a2d to 2977c58 Compare February 19, 2026 18:09
Copy link
Copy Markdown
Contributor

@bolekk bolekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like all new code is properly feature-flagged in application/delegate/syncer. I don't mind merging it once it's rebased on develop.

Comment thread core/services/chainlink/application.go Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

✅ No conflicts with other open PRs targeting develop

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

CORA - Pending Reviewers

All codeowners have approved! ✅

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

Comment thread system-tests/tests/smoke/cre/v2_sharding_test.go Outdated
Comment thread system-tests/tests/smoke/cre/v2_sharding_test.go Outdated
Comment thread system-tests/tests/smoke/cre/v2_sharding_test.go Outdated
Comment thread system-tests/tests/smoke/cre/v2_sharding_test.go Outdated
Comment thread system-tests/tests/smoke/cre/v2_sharding_test.go
Comment thread system-tests/tests/smoke/cre/v2_sharding_test.go Outdated
Comment thread system-tests/tests/smoke/cre/v2_sharding_test.go Outdated
Comment thread system-tests/tests/smoke/cre/v2_sharding_test.go
Copy link
Copy Markdown
Contributor

@Tofel Tofel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving system-tests/* part

@cl-sonarqube-production
Copy link
Copy Markdown

@mchain0 mchain0 requested a review from bolekk February 23, 2026 15:00
@mchain0 mchain0 marked this pull request as ready for review February 23, 2026 15:07
@mchain0 mchain0 requested review from a team as code owners February 23, 2026 15:07
@mchain0 mchain0 enabled auto-merge February 23, 2026 16:35
@mchain0 mchain0 added this pull request to the merge queue Feb 24, 2026
Merged via the queue into develop with commit aa1ce71 Feb 24, 2026
225 checks passed
@mchain0 mchain0 deleted the cre-1714-ring-test-real-workflows branch February 24, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants