Skip to content

feat(ci): advanced triggers for integration-tests #21686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erikburt wants to merge 1 commit into from
Closed

feat(ci): advanced triggers for integration-tests #21686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 61 additions & 37 deletions .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,47 +96,71 @@
name: integration
deployment: false
outputs:
general-changes: ${{ steps.changes.outputs.general_changes }}
core-changes: ${{ steps.changes.outputs.core_changes }}
cre-changes: ${{ steps.changes.outputs.cre_changes }}
ccip-changes: ${{ steps.changes.outputs.ccip_changes }}
cre-e2e: ${{ steps.advanced-triggers.outputs.cre-e2e }}
core-e2e: ${{ steps.advanced-triggers.outputs.core-e2e }}
ccip-e2e: ${{ steps.advanced-triggers.outputs.ccip-e2e }}
steps:
- name: Checkout the repo
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
persist-credentials: false
repository: smartcontractkit/chainlink
ref: ${{ inputs.cl_ref }}

- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
- name: Advanced Triggers
uses: smartcontractkit/.github/actions/advanced-triggers@advanced-triggers/v1

Check warning on line 111 in .github/workflows/integration-tests.yml

View workflow job for this annotation

GitHub Actions / Validate Workflow Changes 

  1. Action is using node20. Versions older than node24 are being deprecated. Use a newer version of the action if possible. (node-version / warning)
Comment thread
erikburt marked this conversation as resolved.
id: advanced-triggers
with:
filters: |
general_changes:
- '.github/workflows/integration-tests.yml'
- '.github/workflows/run-e2e-tests-reusable-workflow.yml'
- '.github/workflows/cre-system-tests.yaml'
- '.github/e2e-tests.yml'
- 'GNUmakefile'
- 'core/chainlink.Dockerfile'
- 'plugins/chainlink.Dockerfile'
core_changes: &core_changes
- '**/*.go'
- '**/*go.sum'
- '**/*go.mod'
- '**/*Dockerfile'
- 'core/**/migrations/*.sql'
- 'core/**/config/**/*.toml'
- 'integration-tests/**/*.toml'
cre_changes:
- *core_changes
- 'core/scripts/cre/environment/**/*'
- 'system-tests/**'
- 'plugins/plugins.private.yaml'
- 'plugins/plugins.public.yaml'
ccip_changes:
- '**/*ccip*'
- '**/*ccip*/**'
file-sets: |
Copy link
Copy Markdown
Collaborator

@kalverra kalverra Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any tests on before-after for this?

Copy link
Copy Markdown
Collaborator Author

@erikburt erikburt Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.

  • Could maybe retroactively compute them?
  • Or I could run this in parrallel with existing logic, with this being more of a "no-op" and logging the run conditions as we roll it out?

I think the biggest benefit will come from ignoring core _test.go and testdata changes and deployment module changes when choosing what to run.

Copy link
Copy Markdown
Collaborator Author

@erikburt erikburt Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could run this in parrallel with existing logic, with this being more of a "no-op" and logging the run conditions as we roll it out?

This is what I did for changed-modules-go, and was able to validate it well enough. I think I will switch it to this.

go-files:
- "**/*.go"
- "**/go.mod"
- "**/go.sum"
core-files:
- "GNUmakefile"
- "core/**/*.go"
- "core/**/migrations/*.sql"
- "core/**/config/**/*.toml"
workflow-files:
- ".github/workflows/integration-tests.yml"
- ".github/actions/**/*.y*ml"
docker-files:
- "**/*Dockerfile"
- "plugins/plugins.public.yaml"
- "plugins/plugins.private.yaml"
legacy-integ-test-files:
- "integration-tests/**"
- ".github/e2e-tests.yml"
system-test-files:
- "system-tests/**"
- "core/scripts/cre/**"
- ".github/workflows/cre-system-tests.yaml"
- ".github/workflows/cre-regression-system-tests.yaml"
core-test-files:
- "testdata/**"
- "core/**/testdata/**"
- "core/**/*_test.go"
deployment-test-files:
- "deployment/**/*_test.go"
- "deployment/**/testdata/**"
triggers: |
cre-e2e:
exclusion-sets: [ core-test-files, deployment-test-files, legacy-integ-test-files ]
inclusion-sets: [ go-files, core-files, workflow-files, docker-files, system-test-files ]
paths:
- "!deployment/**"
core-e2e: # also triggers solana tests
exclusion-sets: [ core-test-files, deployment-test-files, system-test-files ]
inclusion-sets: [ go-files, core-files, workflow-files, docker-files, legacy-integ-test-files ]
paths:
Comment thread
erikburt marked this conversation as resolved.
Comment thread
erikburt marked this conversation as resolved.
- "!deployment/**"
ccip-e2e:
exclusion-sets: [ core-test-files, deployment-test-files, system-test-files ]
inclusion-sets: [ go-files, core-files, workflow-files, docker-files, legacy-integ-test-files ]
paths:
- "!deployment/**"
- "**/*ccip*"
- "**/*ccip*/**"

labels:
name: Get PR labels and set runner labels
Expand Down Expand Up @@ -312,7 +336,7 @@
env:
GITHUB_EVENT_NAME: ${{ github.event_name }}
GITHUB_REF_TYPE: ${{ github.ref_type }}
CONTAINS_CHANGES: ${{ needs.changes.outputs.general-changes == 'true' || needs.changes.outputs.cre-changes == 'true' }}
CONTAINS_CHANGES: ${{ needs.changes.outputs.cre-e2e }}
RUN_E2E_TESTS_LABEL_FOUND: ${{ needs.labels.outputs.run-e2e-tests-label-found }}
run: |
SHOULD_RUN="false"
Expand Down Expand Up @@ -420,7 +444,7 @@
env:
GITHUB_EVENT_NAME: ${{ github.event_name }}
GITHUB_REF_TYPE: ${{ github.ref_type }}
CONTAINS_CHANGES: ${{ needs.changes.outputs.general-changes == 'true' || needs.changes.outputs.core-changes == 'true' }}
CONTAINS_CHANGES: ${{ needs.changes.outputs.core-e2e }}
RUN_E2E_TESTS_LABEL_FOUND: ${{ needs.labels.outputs.run-e2e-tests-label-found || 'false' }}
run: |
if [[ "${GITHUB_EVENT_NAME}" == 'pull_request' ]]; then
Expand Down Expand Up @@ -519,7 +543,7 @@
env:
GITHUB_EVENT_NAME: ${{ github.event_name }}
GITHUB_REF_TYPE: ${{ github.ref_type }}
CONTAINS_CHANGES: ${{ needs.changes.outputs.general-changes == 'true' || needs.changes.outputs.core-changes == 'true' }}
CONTAINS_CHANGES: ${{ needs.changes.outputs.ccip-e2e }}
RUN_E2E_TESTS_LABEL_FOUND: ${{ needs.labels.outputs.run-e2e-tests-label-found || 'false' }}
run: |
if [[ "${GITHUB_EVENT_NAME}" == 'pull_request' ]]; then
Expand Down Expand Up @@ -740,7 +764,7 @@
env:
GITHUB_EVENT_NAME: ${{ github.event_name }}
GITHUB_REF_TYPE: ${{ github.ref_type }}
CONTAINS_CHANGES: ${{ needs.changes.outputs.general-changes == 'true' || needs.changes.outputs.core-changes == 'true' }}
CONTAINS_CHANGES: ${{ needs.changes.outputs.core-e2e }}
RUN_E2E_TESTS_LABEL_FOUND: ${{ needs.labels.outputs.run-e2e-tests-label-found || 'false' }}
INPUTS_RUN_SOLANA: ${{ inputs.run_solana }}
run: |
Expand Down
Loading