Skip to content

core/services/workflows/syncerlimiter: expand keyedOwnerSettings to check default settings.Getter#21687

Open
jmank88 wants to merge 1 commit intodevelopfrom
CRE-2604-atomic-settings-owner-fix
Open

core/services/workflows/syncerlimiter: expand keyedOwnerSettings to check default settings.Getter#21687
jmank88 wants to merge 1 commit intodevelopfrom
CRE-2604-atomic-settings-owner-fix

Conversation

@jmank88
Copy link
Contributor

@jmank88 jmank88 commented Mar 24, 2026

https://smartcontract-it.atlassian.net/browse/CRE-2604

This bridge hack was added before AtomicSettings were passed around, but ends up overwriting them and went unnoticed until now.

@github-actions
Copy link
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2026

✅ No conflicts with other open PRs targeting develop

@jmank88 jmank88 requested review from bolekk and bryan-maxwell March 24, 2026 23:14
@trunk-io
Copy link

trunk-io bot commented Mar 24, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Test_CRE_V2_Suite_Bucket_B/[v2]_Vault_DON_-_workflow-gateway-capabilities/basic_crud The test failed because the expected HTTP response code was 200, but the actual response code was 500, indicating a server error. Logs ↗︎
Test_CRE_V2_Suite_Bucket_B/[v2]_Vault_DON_-_workflow-gateway-capabilities The test failed because it could not retrieve the vault public key due to the plugin not being initialized. Logs ↗︎

View Full Report ↗︎Docs

pavel-raykov
pavel-raykov previously approved these changes Mar 25, 2026
@jmank88 jmank88 marked this pull request as ready for review March 26, 2026 00:30
@jmank88 jmank88 requested a review from a team as a code owner March 26, 2026 00:30
@jmank88 jmank88 marked this pull request as draft March 26, 2026 00:52
@jmank88 jmank88 force-pushed the CRE-2604-atomic-settings-owner-fix branch from 56a2aad to 2c4060c Compare March 26, 2026 00:53
@jmank88 jmank88 marked this pull request as ready for review March 26, 2026 00:54
@jmank88 jmank88 requested a review from pavel-raykov March 26, 2026 00:54
@cl-sonarqube-production
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants