Skip to content

[DX-3565] remove all unused integration-tests code#21693

Open
Tofel wants to merge 4 commits intodevelopfrom
codex/dx-3565-remove-unused-integrationtest-code
Open

[DX-3565] remove all unused integration-tests code#21693
Tofel wants to merge 4 commits intodevelopfrom
codex/dx-3565-remove-unused-integrationtest-code

Conversation

@Tofel
Copy link
Contributor

@Tofel Tofel commented Mar 25, 2026

All legacy tests apart from CCIP were moved to devenv. This PR removes unused helper, configs, contract wrappers, etc.

Added allow-lint-issues label to skip fixing existing issues with legacy CCIP tests.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2026

✅ No conflicts with other open PRs targeting develop

@Tofel Tofel added allow-lint-issues Allow merging despite linter issues. Do not abuse. labels Mar 25, 2026
@trunk-io
Copy link

trunk-io bot commented Mar 25, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@Tofel Tofel force-pushed the codex/dx-3565-remove-unused-integrationtest-code branch from 4a20436 to 13a419b Compare March 25, 2026 17:10
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
20.7% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube

@Tofel Tofel marked this pull request as ready for review March 25, 2026 18:31
@Tofel Tofel requested review from a team as code owners March 25, 2026 18:31
Copilot AI review requested due to automatic review settings March 25, 2026 18:31
@Tofel Tofel requested a review from a team as a code owner March 25, 2026 18:31
@Tofel Tofel requested a review from kalverra March 25, 2026 18:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes legacy/non-CCIP integration-test helpers, configs, contract wrappers, and CLI tooling that are no longer used after moving tests to devenv, while keeping a small set of shared types/utilities needed by remaining suites.

Changes:

  • Deleted large sets of legacy integration-test configs, test suites, and helper code (automation/VRF/OCR/docker tooling).
  • Removed node coverage report tooling from the docker test env and deleted related helper utilities.
  • Introduced a smaller contracts surface and added a consolidated teardown/funds-transfer helper (actions/teardown.go); updated dependency graph docs.

Reviewed changes

Copilot reviewed 57 out of 164 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
integration-tests/testconfig/automation/overrides/benchmark/1000Upkeeps-1h-2_3.toml Removed unused benchmark override config.
integration-tests/testconfig/automation/overrides/benchmark/1000Upkeeps-1h-2_1.toml Removed unused benchmark override config.
integration-tests/testconfig/automation/example.toml Removed unused example config.
integration-tests/testconfig/automation/automation.toml Removed legacy automation default config.
integration-tests/scripts/show_coverage.go Removed unused coverage aggregation script.
integration-tests/runner_helpers.go Removed legacy GH workflow runner helper.
integration-tests/main.go Removed legacy GH workflow runner CLI entrypoint.
integration-tests/load/go.mod Dropped unused indirect deps.
integration-tests/docker/test_env/test_env.go Removed node coverage report handling from cleanup.
integration-tests/docker/node_coverage_helper.go Removed unused node coverage helper implementation.
integration-tests/docker/cmd/main.go Removed unused docker env CLI.
integration-tests/docker/cmd/internal/commands.go Removed unused docker env CLI command implementation.
integration-tests/contracts/test_contracts.go Removed unused test contract wrapper(s).
integration-tests/contracts/multicall.go Removed outdated comment.
integration-tests/contracts/ethereum_vrf_common.go Removed legacy VRF common helpers.
integration-tests/contracts/ethereum_keeper_contracts.go Removed legacy keeper contracts interfaces/models.
integration-tests/contracts/ethereum_contracts_atlas.go Removed legacy atlas-related contract wrappers.
integration-tests/contracts/ethereum/KeeperRegistryVersions.go Removed legacy keeper registry version enum file.
integration-tests/contracts/contracts.go Added reduced set of shared contract/node interfaces and helper conversion.
integration-tests/contracts/contract_vrf_models.go Removed legacy VRF contract models.
integration-tests/contracts/contract_models.go Removed large legacy contracts interface/model aggregation.
integration-tests/benchmark/automation_test.go Removed legacy automation benchmark test suite.
integration-tests/actions/vrf/vrfv2plus/models.go Removed legacy VRFv2+ models.
integration-tests/actions/vrf/vrfv2plus/logging_helpers.go Removed legacy VRFv2+ logging helpers.
integration-tests/actions/vrf/vrfv2plus/errors.go Removed legacy VRFv2+ error constants.
integration-tests/actions/vrf/vrfv2/setup_steps.go Removed legacy VRFv2 setup steps.
integration-tests/actions/vrf/vrfv2/models.go Removed legacy VRFv2 models.
integration-tests/actions/vrf/vrfv2/logging_helpers.go Removed legacy VRFv2 logging helpers.
integration-tests/actions/vrf/vrfv2/errors.go Removed legacy VRFv2 error constants.
integration-tests/actions/vrf/vrfv1/actions.go Removed legacy VRFv1 actions.
integration-tests/actions/vrf/common/models.go Removed legacy VRF common models.
integration-tests/actions/vrf/common/logging_helpers.go Removed legacy VRF common logging helpers.
integration-tests/actions/vrf/common/errors.go Removed legacy VRF common error constants.
integration-tests/actions/vrf/common/actions.go Removed legacy VRF common actions.
integration-tests/actions/teardown.go Added consolidated teardown + funds transfer utilities used by remaining tests.
integration-tests/actions/private_network.go Removed legacy private network config helper.
integration-tests/actions/ocr_helpers_local.go Removed legacy OCR local helpers.
integration-tests/actions/ocr_helpers.go Removed legacy OCR k8s helpers.
integration-tests/actions/ocr2_helpers_local.go Removed legacy OCR2 local helpers.
integration-tests/actions/ocr2_helpers.go Removed legacy OCR2 k8s helpers.
integration-tests/actions/keeper_helpers_local.go Removed legacy keeper local helpers.
integration-tests/actions/contracts.go Removed legacy LinkTokenContract helper indirection.
integration-tests/actions/automation_ocr_helpers_local.go Removed legacy automation OCR local helpers.
integration-tests/actions/automation_ocr_helpers.go Removed legacy automation OCR/k8s helpers.
go.md Updated dependency graph edges to reflect moved/renamed test areas.

@Tofel Tofel enabled auto-merge March 26, 2026 07:00
@Tofel Tofel requested a review from anirudhwarrier March 26, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

allow-lint-issues Allow merging despite linter issues. Do not abuse.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants