Skip to content

[DX-3383] Increase Docker Build runner power #21699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kalverra wants to merge 1 commit into from
Closed

[DX-3383] Increase Docker Build runner power #21699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,8 @@ jobs:
GH_BUILDER_RUNNER: ubuntu22.04-8cores-32GB
GH_SOLANA_RUNNER: ubuntu22.04-8cores-32GB
# include unique label (core/plugins/solana) to ensure jobs are not competing for the same runner
SH_BUILDER_RUNNER_CORE: runs-on=${{ github.run_id }}-core/cpu=32+36/memory=64+72/family=c6i+c7i+c5.*/extras=s3-cache+tmpfs
SH_BUILDER_RUNNER_PLUGINS: runs-on=${{ github.run_id }}-plugins/cpu=32+36/memory=64+72/family=c6i+c7i+c5.*/extras=s3-cache+tmpfs
SH_BUILDER_RUNNER_CORE: runs-on=${{ github.run_id }}-core/cpu=64+72/memory=128+192/family=c6i+c7i+c5.*/extras=s3-cache+tmpfs
SH_BUILDER_RUNNER_PLUGINS: runs-on=${{ github.run_id }}-plugins/cpu=64+72/memory=128+192/family=c6i+c7i+c5.*/extras=s3-cache+tmpfs
Comment on lines +183 to +184
Copy link
Copy Markdown
Collaborator

@erikburt erikburt Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't really seem like it's saving 30 seconds consistently. First other run I found showed a 10 second difference:

Copy link
Copy Markdown
Collaborator

@erikburt erikburt Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can look at the resource metrics now as gathered by runs-on/action:

Old setup doesn't saturate the CPU: https://github.com/smartcontractkit/chainlink/actions/runs/23553695576/job/68574579076#step:13:46

So is it bottlenecked on a few cores?

Copy link
Copy Markdown
Collaborator

@erikburt erikburt Mar 25, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speed up could be from the runner queue time, and favouring more resourceful ec2 instances, might make them more available?

Copy link
Copy Markdown
Collaborator

@erikburt erikburt Mar 25, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could start trying to cache docker layers?

chainlink-ccv has this setup: https://github.com/smartcontractkit/chainlink-ccv/blob/main/.github/actions/build-cl/action.yaml#L43-L47

Would need to wire this into ctf-build-image, and pass it to our internal action which already supports it iirc.

Copy link
Copy Markdown
Collaborator

@erikburt erikburt Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we could adjust these to better support caching?

https://github.com/smartcontractkit/.github/blob/main/actions/ctf-build-image/action.yml#L185C1-L188C62

SH_SOLANA_RUNNER: runs-on=${{ github.run_id }}-solana/cpu=48/ram=96/family=c6i/spot=false/image=ubuntu24-full-x64/extras=s3-cache+tmpfs
run: |
if [[ "${OPT_OUT}" == "true" ]]; then
Expand Down Expand Up @@ -217,7 +217,7 @@ jobs:
matrix:
image:
- name: ""
runner: ${{ needs.labels.outputs.builder-runner-label-core || 'ubuntu22.04-8cores-32GB' }}
runner: ${{ needs.labels.outputs.builder-runner-label-core || 'ubuntu22.04-16cores-64GB' }}
dockerfile: core/chainlink.Dockerfile
Comment on lines 219 to 221
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline || 'ubuntu22.04-16cores-64GB' fallback is probably dead code: needs.labels.outputs.builder-runner-label-core should always be set by the labels job outputs (either to the self-hosted runs-on label or, on opt-out, to GH_BUILDER_RUNNER). Consider removing the fallback to avoid confusion, or keep it but align it with the opt-out runner so defaults don’t drift.

Copilot uses AI. Check for mistakes.
tag-suffix: ""
# todo: optimize this conditional
Expand All @@ -230,7 +230,7 @@ jobs:
}}

- name: (plugins)
runner: ${{ needs.labels.outputs.builder-runner-label-plugins || 'ubuntu22.04-8cores-32GB' }}
runner: ${{ needs.labels.outputs.builder-runner-label-plugins || 'ubuntu22.04-16cores-64GB' }}
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for plugins: || 'ubuntu22.04-16cores-64GB' is likely unused given the labels job always sets the runner label output. Consider removing it (or aligning defaults) to keep runner selection logic simpler.

Suggested change
runner: ${{ needs.labels.outputs.builder-runner-label-plugins || 'ubuntu22.04-16cores-64GB' }}
runner: ${{ needs.labels.outputs.builder-runner-label-plugins }}

Copilot uses AI. Check for mistakes.
dockerfile: plugins/chainlink.Dockerfile
tag-suffix: -plugins
# todo: optimize this conditional
Expand Down
Loading