fix(proposalutils): remove duplicate Timelock nil check in TimelockConfig.Validate#21711
Open
cuiweixie wants to merge 1 commit intosmartcontractkit:developfrom
Open
Conversation
…nfig.Validate Timelock presence is already validated at the start of Validate; drop the redundant check before callProxy validation.
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: LOW
Removes a redundant s.Timelock == nil validation in TimelockConfig.Validate within the deployment proposal utilities. The function already checks s.Timelock near the beginning, so the later check was unreachable duplication.
Changes:
- Delete the duplicate
missing timelocknil-check inTimelockConfig.Validate.
graham-chainlink
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes a redundant
s.Timelock == nilcheck inTimelockConfig.Validate. Timelock is already validated at the beginning of the function.Testing