Skip to content

fix(web/loader): use job not found for missing external job ID batch slots #21712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cuiweixie wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(web/loader): use job not found for missing external job ID batch slots #21712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/web/loader/job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ func (b *jobBatcher) loadByExternalJobIDs(ctx context.Context, keys dataloader.K
}
}

// fill array positions without any feeds managers
// fill array positions without any jobs
for _, ix := range keyOrder {
results[ix] = &dataloader.Result{Data: nil, Error: errors.New("feeds manager not found")}
results[ix] = &dataloader.Result{Data: nil, Error: errors.New("job not found")}
}
Comment on lines +58 to 61
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change alters the observable error for missing external job IDs, but there is no unit test covering the "missing slot" behavior for JobsByExternalJobIDs (loader_test.go only covers the success case). Add a test that requests multiple external IDs with at least one not returned by the ORM and assert the missing position returns "job not found" (matching the pipeline-spec path).

Copilot generated this review using guidance from repository custom instructions.

return results
Expand Down
Loading