Skip to content

fix(ci): unique integration test image tags#21713

Draft
erikburt wants to merge 2 commits intodevelopfrom
fix/integ-test-image-tag
Draft

fix(ci): unique integration test image tags#21713
erikburt wants to merge 2 commits intodevelopfrom
fix/integ-test-image-tag

Conversation

@erikburt
Copy link
Collaborator

@erikburt erikburt commented Mar 26, 2026

I noticed that pushes to develop were using the image made during the merge_group as the sha refs were the same, and we dedupe image builds based on existing refs.

This is bad because we want pushes to develop to build an image, so they can populate the docker layer cache.

  • Merge groups don't populate the docker layer cache because basically nothing would ever actually use them. This is because only caches from the default branch, or the current branch can be restored from
    • ie. no cross feature branch cache sharing for security reasons

Changes

  • Adds a shortform event name to the image name
  • Outputs the image tags from the job instead of inferring the expected tag

@erikburt erikburt self-assigned this Mar 26, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2026

✅ No conflicts with other open PRs targeting develop

@erikburt erikburt added the run-e2e-tests Use on your PR to run E2E tests before the merge queue label Mar 26, 2026
@trunk-io
Copy link

trunk-io bot commented Mar 26, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-e2e-tests Use on your PR to run E2E tests before the merge queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant