vault: add generic authorizer with jwt auth support#21714
Open
prashantkumar1982 wants to merge 12 commits intodevelopfrom
Open
vault: add generic authorizer with jwt auth support#21714prashantkumar1982 wants to merge 12 commits intodevelopfrom
prashantkumar1982 wants to merge 12 commits intodevelopfrom
Conversation
product-security-plaid-production
bot
requested review from
archseer and
justinkaseman
…th-authorizer # Conflicts: # core/capabilities/vault/gw_handler.go # core/capabilities/vault/gw_handler_test.go # core/services/ocr2/delegate.go
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
|
I see you updated files related to
|
Contributor
Author
There was a problem hiding this comment.
This file is pretty much just a rename of previous request_authorizer.go file
|
- Cap JWKS response body to 1 MB to prevent resource exhaustion - Make all AuthResult fields unexported with accessor methods - Add iat claim validation to JWT parser - Annotate unreachable return in allowlist retry loop - Fix misleading test name for digest verification delegation Made-with: Cursor
prashantkumar1982
force-pushed
the
codex/vault-gwt-auth-authorizer
branch
from
77cda12 to
68f66e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds the Vault auth abstraction needed for gateway-side JWT support while keeping current behavior unchanged because JWT auth remains disabled.
What changed
Authorizerused by both the Vault gateway handler and the Vault capability gateway handlerAllowListBasedAuthandJWTBasedAuthAuthResultcontract and a sharedRequestReplayGuardJWTBasedAuth, gated internally and failing closed when disabledBehavior