Skip to content

plugins: add btrfs plugin#970

Closed
0x666c697473 wants to merge 1 commit intosnapshotmanager:mainfrom
0x666c697473:btrfs
Closed

plugins: add btrfs plugin#970
0x666c697473 wants to merge 1 commit intosnapshotmanager:mainfrom
0x666c697473:btrfs

Conversation

@0x666c697473
Copy link
Copy Markdown

Resolves: #840

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 4, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bd249014-f7e3-417e-a041-401338fb63a0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bmr-cymru
Copy link
Copy Markdown
Contributor

The CI failure is due to code formatting issues - run black snapm and it will fix those up.

Resolves: snapshotmanager#840

Signed-off-by: Mark Flitter <flits@flits.co.uk>
@bmr-cymru
Copy link
Copy Markdown
Contributor

Need to add the new plugin file to the RPM files list.. that's what's up with the RPM builds.

@bmr-cymru
Copy link
Copy Markdown
Contributor

Oh also this:

=================================== FAILURES ===================================
_____________________ LoaderTestsSimple.test_load_plugins ______________________

self = <tests.test_loader.LoaderTestsSimple testMethod=test_load_plugins>

    def test_load_plugins(self):
        plugin_classes = load_plugins()
>       self.assertEqual(len(plugin_classes), 3)
E       AssertionError: 4 != 3

There's a slightly silly thing in the test suite where we hard code the number of plugins in test_load_plugins; I should fix that properly, but for now it's fine to just s/3/4 in teh test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

plugins: add Btrfs plugin

2 participants