feat: emit a "session-expiry" event when a session has expired#5478
Open
976520 wants to merge 1 commit intosocketio:mainfrom
Open
feat: emit a "session-expiry" event when a session has expired#5478976520 wants to merge 1 commit intosocketio:mainfrom
976520 wants to merge 1 commit intosocketio:mainfrom
Conversation
Member
|
Hi! Thanks for the pull request. Could you please explain your use case for this feature? |
Author
|
Sure!! When using connection state recovery, there's currently no way to know when a persisted session has expired. This makes it difficult to perform cleanup logic tied to session lifetime e.g.
Without this event, the only option is to poll or rely on external timeouts, which are harder to synchronize with the actual expiry logic inside SessionAwareAdapter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
When a session expires and is removed in SessionAwareAdapter, no event is emitted, making it impossible for external consumers to detect when a session has expired.
New behavior
SessionAwareAdapter now emits a "session-expiry" event whenever an expired session is deleted. The event handler receives the sid of the expired session as an argument.
Other information (e.g. related issues)
#5250