[Framework] Apply template method design pattern to BaseMaterial#5439
Open
NiziL wants to merge 4 commits intosofa-framework:masterfrom
Open
[Framework] Apply template method design pattern to BaseMaterial#5439NiziL wants to merge 4 commits intosofa-framework:masterfrom
NiziL wants to merge 4 commits intosofa-framework:masterfrom
Conversation
NiziL
added
pr: breaking
Author
|
[ci-build][with-all-tests] |
.../FEM/HyperElastic/src/sofa/component/solidmechanics/fem/hyperelastic/material/BaseMaterial.h
Show resolved
Hide resolved
.../FEM/HyperElastic/src/sofa/component/solidmechanics/fem/hyperelastic/material/BaseMaterial.h
Show resolved
Hide resolved
.../FEM/HyperElastic/src/sofa/component/solidmechanics/fem/hyperelastic/material/BaseMaterial.h
Show resolved
Hide resolved
bakpaul
added
pr: status to review
bakpaul
added a commit
that referenced
this pull request
Apr 10, 2026
commit 370b6c4 Merge: 8d4aacd 912335e Author: Paul Baksic <30337881+bakpaul@users.noreply.github.com> Date: Fri Apr 10 09:25:36 2026 +0200 Merge branch 'master' into 2025_sedsprint_BaseMaterial commit 8d4aacd Merge: a099baa fb6ac6c Author: Paul Baksic <30337881+bakpaul@users.noreply.github.com> Date: Tue Jan 6 11:42:09 2026 +0100 Merge branch 'master' into 2025_sedsprint_BaseMaterial commit a099baa Author: Théo BL <theo.biasutto-lervat@inria.fr> Date: Mon May 12 15:22:49 2025 +0200 refacto: ensure naming consistency commit e20ce58 Author: Théo BL <theo.biasutto-lervat@inria.fr> Date: Mon May 12 15:17:53 2025 +0200 feat(sed_sprint): apply template method to BaseMaterial
bakpaul
added
pr: status wip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SED Sprint 2025
Base class
BaseMaterial, function modified:computeStress (type::Vec3 & stress, type::Vec3 & strain, unsigned int & elementIndex)computeDStress (type::Vec3 & dstress, type::Vec3 & dstrain)computeStress (unsigned int elementIndex)Child classes modified:
PlasticMaterialBy submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if