Skip to content

[Framework] Apply template method design pattern to ConstraintSolver#5457

Open
olivierrochel-inria wants to merge 4 commits intosofa-framework:masterfrom
olivierrochel-inria:2025_sprintsed_ConstraintSolver
Open

[Framework] Apply template method design pattern to ConstraintSolver#5457
olivierrochel-inria wants to merge 4 commits intosofa-framework:masterfrom
olivierrochel-inria:2025_sprintsed_ConstraintSolver

Conversation

@olivierrochel-inria
Copy link
Copy Markdown

@olivierrochel-inria olivierrochel-inria commented May 13, 2025

Changed:

  • solveConstraint
  • prepareStates
  • buildSystem
  • rebuildSystem
  • solveSystem
  • applyCorrection
  • computeResidual
  • removeConstraintCorrection

[ci-depends-on https://github.com/SofaDefrost/SoftRobots.Inverse/pull/82]
[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@olivierrochel-inria olivierrochel-inria added pr: breaking Change possibly inducing a compilation error pr: status wip Development in the pull-request is still in progress refactoring Refactor code labels May 13, 2025
@olivierrochel-inria
Copy link
Copy Markdown
Author

[ci-build][with-all-tests]

@olivierrochel-inria
Copy link
Copy Markdown
Author

[ci-build][with-all-tests]

@bakpaul bakpaul added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Jan 6, 2026
@bakpaul bakpaul self-assigned this Jan 6, 2026
@bakpaul
Copy link
Copy Markdown
Contributor

bakpaul commented Apr 8, 2026

[ci-build][force-full-build]

@sofabot
Copy link
Copy Markdown
Collaborator

sofabot commented Apr 8, 2026

[ci-depends-on] detected during build #8.

To unlock the merge button, you must

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: breaking Change possibly inducing a compilation error pr: status to review To notify reviewers to review this pull-request refactoring Refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants