Skip to content

[Framework] Apply template method design pattern to BaseConstraintSet#5478

Open
bakpaul wants to merge 2 commits intosofa-framework:masterfrom
bakpaul:2025_sprintsed_baseconstraintset
Open

[Framework] Apply template method design pattern to BaseConstraintSet#5478
bakpaul wants to merge 2 commits intosofa-framework:masterfrom
bakpaul:2025_sprintsed_baseconstraintset

Conversation

@bakpaul
Copy link
Copy Markdown
Contributor

@bakpaul bakpaul commented May 14, 2025

Apply pattern to :

  • resetConstraint
  • buildConstraintMatrix
  • processGeometricalData
  • getConstraintViolation
  • getConstraintViolation

[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/327]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@bakpaul bakpaul added pr: breaking Change possibly inducing a compilation error pr: status wip Development in the pull-request is still in progress refactoring Refactor code labels May 14, 2025
@bakpaul
Copy link
Copy Markdown
Contributor Author

bakpaul commented May 14, 2025

[ci-build][with-all-tests]

@sofabot
Copy link
Copy Markdown
Collaborator

sofabot commented May 14, 2025

[ci-depends-on] detected during build #2.

To unlock the merge button, you must

@hugtalbot hugtalbot force-pushed the 2025_sprintsed_baseconstraintset branch from e3142bb to 402de71 Compare January 6, 2026 11:26
@hugtalbot hugtalbot self-assigned this Jan 6, 2026
@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Jan 6, 2026
@hugtalbot
Copy link
Copy Markdown
Contributor

[ci-build]

@sofabot
Copy link
Copy Markdown
Collaborator

sofabot commented Apr 8, 2026

[ci-depends-on] detected during build #5.

To unlock the merge button, you must

bakpaul added a commit that referenced this pull request Apr 8, 2026
commit b2131c3
Merge: 402de71 25a096d
Author: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
Date:   Wed Apr 8 14:23:26 2026 +0200

    Merge branch 'master' into 2025_sprintsed_baseconstraintset

commit 402de71
Author: hugtalbot <hugo.talbot@inria.fr>
Date:   Tue Jan 6 12:25:45 2026 +0100

    force push - Apply template method design pattern to BaseConstraintSet
@bakpaul bakpaul added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: breaking Change possibly inducing a compilation error pr: status wip Development in the pull-request is still in progress refactoring Refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants