[visual] VisualModelImpl: add resetMaterial variable#6057
Open
EulalieCoevoet wants to merge 1 commit intosofa-framework:masterfrom
Open
[visual] VisualModelImpl: add resetMaterial variable#6057EulalieCoevoet wants to merge 1 commit intosofa-framework:masterfrom
EulalieCoevoet wants to merge 1 commit intosofa-framework:masterfrom
Conversation
hugtalbot
added
pr: enhancement
hugtalbot
approved these changes
Mar 30, 2026
Contributor
hugtalbot
left a comment
hugtalbot
left a comment
There was a problem hiding this comment.
No use in SOFA, but it's the purpose of the PR : anticipating the future need in the GUI
bakpaul
approved these changes
Apr 2, 2026
hugtalbot
requested changes
Apr 9, 2026
Contributor
hugtalbot
left a comment
hugtalbot
left a comment
There was a problem hiding this comment.
@EulalieCoevoet the variable chould be renamed since it is hard to me to understand the meaning of "reset" (I suggested a new name)
Would you mind also:
- set the member variable as protected
- and add a getter
| d_scale.setValue(Vec3Real(1, 1, 1)); | ||
| } | ||
|
|
||
| m_resetMaterial = d_material.getValue(); |
Contributor
There was a problem hiding this comment.
Suggested change
| m_resetMaterial = d_material.getValue(); | |
| m_savedMaterial = d_material.getValue(); |
| sofa::type::Vec3f bbox[2]; | ||
|
|
||
| Data< sofa::type::Material > d_material; | ||
| sofa::type::Material m_resetMaterial; |
Contributor
There was a problem hiding this comment.
Suggested change
| sofa::type::Material m_resetMaterial; | |
| sofa::type::Material m_savedMaterial; //> Store the material information, useful to highlight the objects of the selected node |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store the material in a new variable
resetMaterial.This allows to highlight the objects of the selected node.
2026-03-27_16-42-43.mp4
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if