fix: deprecate unused SimpleTimer header#6076
fix: deprecate unused SimpleTimer header#6076mvanhorn wants to merge 1 commit intosofa-framework:masterfrom
Conversation
SimpleTimer.h is not used anywhere in the codebase. Mark it as deprecated with SOFA_HEADER_DEPRECATED for removal in v27.06.
|
Hi @mvanhorn Our contribution rules state that: Your PR seems to violate this contribution rule. I therefore close this PR. Reviewers' time is precious. Such a contribution neglects it. |
|
Hi @hugtalbot, thanks for the feedback. You're right that this was a lightweight change, and I understand the concern about automated contributions consuming reviewer time. I came across issue #5214 filed by @alxbilger and thought it was a straightforward fix I could help with. I used AI tooling to assist with the implementation but did verify the grep results and the deprecation macro usage myself. That said, I recognize this kind of minimal-touch contribution can feel like noise rather than help, and I appreciate you explaining your expectations. I'll be more thoughtful about the scope and depth of any future contributions here. Apologies for the wasted review cycle. |
Summary
Marks
Sofa/framework/Helper/src/sofa/helper/SimpleTimer.has deprecated usingSOFA_HEADER_DEPRECATED. The header has no usages anywhere in the codebase and can be safely deprecated for later removal.Changes
Sofa/framework/Helper/src/sofa/helper/SimpleTimer.h: AddedSOFA_HEADER_DEPRECATED("v26.06", "v27.06", "This header is unused and will be removed.")and includedsofa/helper/config.hfor the macro definition.Verified with
grep -rn "SimpleTimer"across the entire codebase - no includes or references outside the header file itself.Fixes #5214
This contribution was developed with AI assistance (Claude Code).