Skip to content

refactor: simpler implementations #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdydek wants to merge 2 commits into
base: main
Choose a base branch
from
+64 −98
Open

refactor: simpler implementations #1006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39e172d
refactor: simpler implementations
mdydek Mar 30, 2026
3c00523
chore: merge
closetcaiman Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 54 additions & 98 deletions packages/react-native-audio-api/common/cpp/audioapi/events/AudioEventHandlerRegistry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,130 +65,86 @@ void AudioEventHandlerRegistry::unregisterHandler(AudioEvent eventName, uint64_t
});
}

// todo: refactor this method to be less complex and more readable
// NOLINTNEXTLINE(readability-function-cognitive-complexity)
jsi::Object AudioEventHandlerRegistry::makeEventObjectForDispatch(
AudioEvent eventName,
const std::unordered_map<std::string, EventValue> &body) {
if (eventName != AudioEvent::AUDIO_READY) {
return createEventObject(body);
}
auto bufferIt = body.find("buffer");
if (bufferIt == body.end()) {
return createEventObject(body);
}
auto bufferHostObject = std::static_pointer_cast<AudioBufferHostObject>(
std::get<std::shared_ptr<jsi::HostObject>>(bufferIt->second));
return createEventObject(body, bufferHostObject->getSizeInBytes());
}

void AudioEventHandlerRegistry::dispatchHandler(
AudioEvent eventName,
const std::shared_ptr<jsi::Function> &handler,
const std::unordered_map<std::string, EventValue> &body) {
if (handler == nullptr || !handler->isFunction(*runtime_)) {
return;
}
try {
jsi::Object eventObject = makeEventObjectForDispatch(eventName, body);
handler->call(*runtime_, eventObject);
} catch (const std::exception &) {
throw;
} catch (...) {
printf("Unknown exception occurred while invoking handler for event: %d\n", eventName);
}
}

void AudioEventHandlerRegistry::invokeHandlerWithEventBody(
AudioEvent eventName,
const std::unordered_map<std::string, EventValue> &body) {
if (runtime_ == nullptr) {
// If runtime is not valid, we cannot unregister the handler
return;
}

auto weakSelf = weak_from_this();

// Read/Write on eventHandlers_ map only on the JS thread
callInvoker_->invokeAsync([weakSelf, eventName, body]() {
if (auto self = weakSelf.lock()) {
auto it = self->eventHandlers_.find(eventName);

if (it == self->eventHandlers_.end()) {
// If the event name is not registered, we can skip invoking handlers
return;
}

auto handlersMap = it->second;

for (const auto &pair : handlersMap) {
auto handler = pair.second;

if (!handler || !handler->isFunction(*self->runtime_)) {
// If the handler is not valid, we can skip it
continue;
}

try {
jsi::Object eventObject(*self->runtime_);
// handle special logic for microphone, because we pass audio buffer
// which has significant size
if (eventName == AudioEvent::AUDIO_READY) {
auto bufferIt = body.find("buffer");
if (bufferIt != body.end()) {
auto bufferHostObject = std::static_pointer_cast<AudioBufferHostObject>(
std::get<std::shared_ptr<jsi::HostObject>>(bufferIt->second));
eventObject = self->createEventObject(body, bufferHostObject->getSizeInBytes());
}
} else {
eventObject = self->createEventObject(body);
}
handler->call(*self->runtime_, eventObject);
} catch (const std::exception &e) {
// re-throw the exception to be handled by the caller
// std::exception is safe to parse by the rn bridge
throw;
} catch (...) {
printf("Unknown exception occurred while invoking handler for event: %d\n", eventName);
}
}
auto self = weakSelf.lock();
if (self == nullptr) {
return;
}
auto it = self->eventHandlers_.find(eventName);
if (it == self->eventHandlers_.end()) {
return;
}
for (const auto &pair : it->second) {
self->dispatchHandler(eventName, pair.second, body);
}
});
}

// todo: refactor this method to be less complex and more readable
// NOLINTNEXTLINE(readability-function-cognitive-complexity)
void AudioEventHandlerRegistry::invokeHandlerWithEventBody(
AudioEvent eventName,
uint64_t listenerId,
const std::unordered_map<std::string, EventValue> &body) {
if (runtime_ == nullptr) {
// If runtime is not valid, we cannot unregister the handler
return;
}

auto weakSelf = weak_from_this();

// Read/Write on eventHandlers_ map only on the JS thread
callInvoker_->invokeAsync([weakSelf, eventName, listenerId, body]() {
if (auto self = weakSelf.lock()) {
auto it = self->eventHandlers_.find(eventName);

if (it == self->eventHandlers_.end()) {
// If the event name is not registered, we can skip invoking handlers
return;
}

auto handlerIt = it->second.find(listenerId);

if (handlerIt == it->second.end()) {
// If the listener ID is not registered, we can skip invoking handlers
return;
}

// Depending on how the AudioBufferSourceNode is handled on the JS side,
// it sometimes might enter race condition where the ABSN is deleted on JS
// side, but it is still processed on the audio thread, leading to a crash
// when f.e. `positionChanged` event is triggered.

// In case of debugging this, please increment the hours spent counter

// Hours spent on this: 8
try {
if (!handlerIt->second || !handlerIt->second->isFunction(*self->runtime_)) {
// If the handler is not valid, we can skip it
return;
}
jsi::Object eventObject(*self->runtime_);
// handle special logic for microphone, because we pass audio buffer which
// has significant size
if (eventName == AudioEvent::AUDIO_READY) {
auto bufferIt = body.find("buffer");
if (bufferIt != body.end()) {
auto bufferHostObject = std::static_pointer_cast<AudioBufferHostObject>(
std::get<std::shared_ptr<jsi::HostObject>>(bufferIt->second));
eventObject = self->createEventObject(body, bufferHostObject->getSizeInBytes());
}
} else {
eventObject = self->createEventObject(body);
}
handlerIt->second->call(*self->runtime_, eventObject);
} catch (const std::exception &e) {
// re-throw the exception to be handled by the caller
// std::exception is safe to parse by the rn bridge
throw;
} catch (...) {
printf("Unknown exception occurred while invoking handler for event: %d\n", eventName);
}
auto self = weakSelf.lock();
if (self == nullptr) {
return;
}
auto it = self->eventHandlers_.find(eventName);
if (it == self->eventHandlers_.end()) {
return;
}
auto handlerIt = it->second.find(listenerId);
if (handlerIt == it->second.end()) {
return;
}
self->dispatchHandler(eventName, handlerIt->second, body);
});
}

Expand Down
10 changes: 10 additions & 0 deletions packages/react-native-audio-api/common/cpp/audioapi/events/AudioEventHandlerRegistry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,16 @@ class AudioEventHandlerRegistry : public IAudioEventHandlerRegistry,
jsi::Object createEventObject(
const std::unordered_map<std::string, EventValue> &body,
size_t memoryPressure);

/// Builds the JS object passed to handlers (AUDIO_READY uses buffer memory pressure).
jsi::Object makeEventObjectForDispatch(
AudioEvent eventName,
const std::unordered_map<std::string, EventValue> &body);

void dispatchHandler(
AudioEvent eventName,
const std::shared_ptr<jsi::Function> &handler,
const std::unordered_map<std::string, EventValue> &body);
};

} // namespace audioapi
Loading