fix: expose unload() JSI binding for TextToImageModule#947
Merged
chmjkb merged 1 commit intosoftware-mansion:mainfrom Mar 9, 2026
Merged
fix: expose unload() JSI binding for TextToImageModule#947chmjkb merged 1 commit intosoftware-mansion:mainfrom
chmjkb merged 1 commit intosoftware-mansion:mainfrom
Conversation
TextToImage.unload() exists in C++ but was never registered as a JSI host function, causing `TypeError: this.nativeModule.unload is not a function` when calling BaseModule.delete() from JS. Every other composite model (OCR, VerticalOCR, Kokoro, LLM) already registers unload in its `if constexpr` block — this adds the same one-liner for TextToImage.
benITo47
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TextToImage::unload()is implemented in C++ and correctly delegates to its sub-components (encoder, unet, decoder), but the JSI binding was never registered inModelHostObject. This causes aTypeError: this.nativeModule.unload is not a functionwhen callingBaseModule.delete()from JavaScript.Every other composite model (OCR, VerticalOCR, Kokoro, LLM) already registers
unloadin itsif constexprblock — this adds the same one-liner for TextToImage.Changes
unloadJSI export to theTextToImageblock inModelHostObject.h, matching the existing pattern used by other modelsTest plan
module.delete()on a loadedTextToImageModule— should no longer throwdelete()(encoder, unet, decoder sub-models are unloaded)