fix(kokoro): register streamStop on JSI host object#951
Merged
msluszniak merged 1 commit intosoftware-mansion:mainfrom Mar 10, 2026
Merged
fix(kokoro): register streamStop on JSI host object#951msluszniak merged 1 commit intosoftware-mansion:mainfrom
msluszniak merged 1 commit intosoftware-mansion:mainfrom
Conversation
Kokoro::streamStop() exists in C++ but was never exposed via JSI in ModelHostObject. This causes a runtime TypeError when TextToSpeechModule.streamStop() tries to call this.nativeModule.streamStop(), which is undefined. Register it as a synchronousHostFunction, matching the pattern used for SpeechToText's streamStop.
msluszniak
approved these changes
Mar 10, 2026
Member
|
Good catch, thank you. :)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Kokoro::streamStop()exists in C++ (Kokoro.cpp:205) and is called from the JSTextToSpeechModule.streamStop()viathis.nativeModule.streamStop(), but it's never registered on the JSI host object inModelHostObject.h.This causes a runtime error when stopping TTS streaming:
The fix registers
streamStopas asynchronousHostFunctionin the Kokoroif constexprblock, matching the existing pattern used forSpeechToText.Changes
ModelHostObject.h: AddstreamStopJSI registration for Kokoro model type