Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Clickable component in the react-native-gesture-handler library, intended to serve as a unified replacement for BaseButton, RectButton, and BorderlessButton. The component supports configurable visual feedback (underlay or whole-component opacity changes) and native Android ripple effects. Supporting changes include extracting visual style properties (background color, border radius, etc.) through to the native button in GestureHandlerButton, type improvements to RawButton and BorderlessButton, and a new example screen.
Changes:
- New
Clickablecomponent with configurable animation feedback (feedbackTarget,feedbackType,activeOpacity,underlayColor) and long-press support GestureHandlerButtonnow passes visual style properties (backgroundColor, borderRadius, border styles) to the nativeButtonComponent, andRawButtongets proper type generics- Example screen demonstrating
Clickablein various configurations (base, rect-like, borderless-like, custom)
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/v3/components/Clickable.tsx |
New Clickable component with animation, long-press, and ripple support |
src/v3/components/index.ts |
Exports Clickable and ClickableProps (from incorrect path) |
src/v3/index.ts |
Re-exports Clickable from components |
src/components/GestureHandlerButton.tsx |
Extracts visual properties (backgroundColor, border*) into buttonStyle passed to native button |
src/v3/components/GestureButtons.tsx |
Adds type generics to RawButton, extracts ref in BorderlessButton |
src/v3/types/NativeWrapperType.ts |
Adds ` |
apps/common-app/src/new_api/components/clickable/index.tsx |
Example screen showcasing Clickable configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/react-native-gesture-handler/src/v3/components/index.ts
Outdated
Show resolved
Hide resolved
packages/react-native-gesture-handler/src/v3/components/Clickable/Clickable.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/react-native-gesture-handler/src/v3/components/Clickable/ClickableProps.ts
Outdated
Show resolved
Hide resolved
packages/react-native-gesture-handler/src/components/GestureHandlerButton.tsx
Show resolved
Hide resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…native-gesture-handler into @mbert/clickable
…lickable component
packages/react-native-gesture-handler/src/v3/components/Clickable/Clickable.tsx
Outdated
Show resolved
Hide resolved
packages/react-native-gesture-handler/src/components/GestureHandlerButton.tsx
Outdated
Show resolved
Hide resolved
packages/react-native-gesture-handler/src/v3/components/Clickable/Clickable.tsx
Show resolved
Hide resolved
packages/react-native-gesture-handler/src/v3/components/Clickable/Clickable.tsx
Outdated
Show resolved
Hide resolved
packages/react-native-gesture-handler/src/v3/components/Clickable/Clickable.tsx
Outdated
Show resolved
Hide resolved
packages/react-native-gesture-handler/src/v3/components/Clickable/Clickable.tsx
Show resolved
Hide resolved
packages/react-native-gesture-handler/src/v3/components/Clickable/Clickable.tsx
Show resolved
Hide resolved
…rictly on hitslop instead (#4038) ## Description Apple enforces a stupidly large retention offset in the default UIControl touch tracking loop, which was conflicting with `shouldCancelWhenOutside` and `hitSlop` props. This PR overrides the default tracking loop to rely only on our props instead. ## Test plan Tested on the example added in #4018
Description
This PR introduces new
Clickablecomponent, which is meant to be a replacement for buttons.Note
Docs for
Clickablewill be added in #4022, as I don't want to release them right away after merging this PR.borderlessFor now,
borderlessdoesn't work. I've tested clickable with some changes that allowborderlessripple to be visible, however we don't want to introduce them here because it would break other things. Also it should be generl fix, not in the PR with new component.Stress test
Render list with 2000 buttons 25 times (50ms delay between renders), drop 3 best and 3 worst results. Then calculate average.
Stress test example is available in this PR.
Android
BaseButtonRectButtonBorderlessButtoniOS
BaseButtonRectButtonBorderlessButtonWeb
BaseButtonRectButtonBorderlessButtonTest plan
New examples