Mocks: fix button content missing#4048
Open
alpha0010 wants to merge 1 commit intosoftware-mansion:2.30-stablefrom
Open
Mocks: fix button content missing#4048alpha0010 wants to merge 1 commit intosoftware-mansion:2.30-stablefrom
alpha0010 wants to merge 1 commit intosoftware-mansion:2.30-stablefrom
Conversation
This makes it impossible for tests to target a button based on displayed elements.
m-bert
requested changes
Apr 1, 2026
| export const RawButton = ({ enabled, children, ...rest }: any) => ( | ||
| <TouchableNativeFeedback disabled={enabled === false} {...rest}> | ||
| <View /> | ||
| {children} |
Contributor
There was a problem hiding this comment.
Suggested change
| {children} | |
| {children ?? <View />} |
Could we please keep View in case where children is undefined?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lacking button content in the provided mocks makes it impossible to write tests such as "is the button with 'foo' rendered" or "press the button with 'bar'".
Test plan