Add Flow.recoverWithRetry operator and Schedule class#281
Open
Add Flow.recoverWithRetry operator and Schedule class#281
Conversation
endrju19
force-pushed
the
feature/recover-with-retry
branch
from
82f0cdb to
03bbc37
Compare
endrju19
force-pushed
the
feature/recover-with-retry
branch
from
7f669a3 to
03bbc37
Compare
Member
|
Hm we don't have retry in jox (there's resilience4j that covers this quite well) so probably this shouldn't go in. But maybe an integration layer betwen jox and resilience4j would? Could we come up with some other flow-related or channel-related operations that might be useful here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recoverWithRetry(schedule, pf)— retries the recovery flow according to a Schedule when upstream failsSchedule— new class with three factories (immediate,fixedInterval,exponentialBackoff) and two modifiers (maxRetries,maxInterval)recoverWithrefactored to delegate torecoverWithRetrywith zero retries, eliminating code duplication8 tests (2 recoverWithRetry + 6 Schedule).