Make the requirement only to support all#374
Closed
kjetilk wants to merge 2 commits intofix/server-link-auxiliary-typefrom
Closed
Make the requirement only to support all#374kjetilk wants to merge 2 commits intofix/server-link-auxiliary-typefrom
kjetilk wants to merge 2 commits intofix/server-link-auxiliary-typefrom
Conversation
Member
|
Updated re #372 . Let's move on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #372, the language is still too fluffy for me, so I suggest just making the requirement to support them all. It doesn't clarify, but then at least it is clear what we can test.
I couldn't see how I just make suggestions, so did it this way.