Example implementation of an audio sender control class#472
Closed
maweit wants to merge 0 commit intosony:masterfrom
Closed
Example implementation of an audio sender control class#472maweit wants to merge 0 commit intosony:masterfrom
maweit wants to merge 0 commit intosony:masterfrom
Conversation
Contributor
|
Hi @maweit. Thank you for your Pull Request - I'll add some review comments to the code. |
| if (sender_data.has_field(U("subscription"))) snd_control_property_descriptors.push_back(nmos::experimental::make_control_class_property_descriptor(U("subscription"), { 3, 11 }, subscription_property, U("NcSenderObjectType"))); | ||
| if (sender_data.has_field(U("transport"))) snd_control_property_descriptors.push_back(nmos::experimental::make_control_class_property_descriptor(U("transport"), { 3, 12 }, transport_property, U("NcString"))); | ||
|
|
||
| auto snd_class_id = nmos::nc::make_class_id(nmos::nc_worker_class_id, 0, { 5 }); |
Contributor
There was a problem hiding this comment.
make_audio_sender_descriptors actually performs two functions - as well as making the audio sender class and datatype descriptors, it also makes the class_id for the audio sender class - I think I'd rather see the class id passed in as a parameter and then the function is only doing one thing.
Author
There was a problem hiding this comment.
Makes sense and i changed that. Please review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added audio sender control class and related data types as an example for audio sender properties and descriptors.