Conversation
Pull Request Test Coverage Report for Build 22718039553Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
s-kybound
left a comment
s-kybound
left a comment
There was a problem hiding this comment.
LGTM except for the utils/scheme folder, should be renamed to something like utils/continuations, or logic should be moved
| setDifference | ||
| } from './CseMachineUtils'; | ||
| import { Continuation, isContinuation, isSchemeNumber, isSymbol } from './utils/scheme'; | ||
| import { Continuation, isContinuation } from './utils/scheme'; |
There was a problem hiding this comment.
Continuation and isContinuation should be moved away from utils/Scheme
OK, I agree. |
|
LGTM! |
RichDom2185
left a comment
RichDom2185
left a comment
There was a problem hiding this comment.
Why are we reverting the updates back to older versions?
|
@sayomaki can you help revert the changes in this PR? |
|
Nevermind, I'll do the revert |
6 participants
Description
This PR bumps js-slang to 1.0.88, which does not include support for the language Scheme. As a result, this PR removes any scheme implementation.
Type of change
How to test
I tested that everything builds and runs locally, and checked that Scheme is no longer available.
Checklist