Conversation
Adimote
requested review from
PeterJCLaw,
RealOrangeOne,
henry-oliver-edwards,
kierdavis and
trickeydan
content/api/vision/coordinates.md
Outdated
There was a problem hiding this comment.
Any reason why X, Y, Z are capitalised and x,y,z are not?
|
@trickeydan I've made additions since you reviewed (my fault), is there any chance you can take another look? |
content/api/vision/coordinates.md
Outdated
There was a problem hiding this comment.
Using the term typically suggests that there is a case where the z axis may not face the camera?
Is it worth mentioning this in the docs?
content/api/vision/_index.md
Outdated
There was a problem hiding this comment.
I don't really like the additional sentence just to link, could we word orientation into the initial one. Perhaps:
returns the [Orientation] of the marker around its centre.
content/api/vision/coordinates.md
Outdated
There was a problem hiding this comment.
Why are we using image tags here rather than the markdown format? I can't see that forcing the margin to 0 is really required here?
There was a problem hiding this comment.
the default margin makes them very spaced out
There was a problem hiding this comment.
Hmm, you're right, that's really annoying. I'll try and fix it with CSS some time!
content/api/vision/coordinates.md
Outdated
There was a problem hiding this comment.
Orientation isnt a coordinate system. I think this section warrants its own page
content/api/vision/coordinates.md
Outdated
There was a problem hiding this comment.
This table is invalid when rendered with Hugo, see https://deploy-preview-121--sourcebots-docs.netlify.com/api/vision/coordinates/#orientation-coordinates
|
Note: I'm holding off reviewing this until sourcebots/sb-vision#34 and sourcebots/robot-api#83 are resolved. |
4 participants
Add page on orientations and a table of images on what each rotation looks like.