Skip to content

Conversation

@NathanBaulch
Copy link
Contributor

@NathanBaulch NathanBaulch commented Jul 11, 2025

Various code improvements. The changes to QueryLocalChanges in particular make the code much easier to understand.

@love-linger
Copy link
Collaborator

I no longer plan to merge this kind of PR.

  1. There are too many code changes, which takes too much time to review.
  2. Sometimes I can't recall the issues that needed to be considered during the coding process, resulting in bugs, such as 2025.26 Can't UNSTAGE files from stage when checked Amend checkbox #1582, 2025.26 doesn't startup if the path has a space in it. #1576, d28bd92, etc.
  3. Most of them are about new syntax or variable initialization suggestions.

@NathanBaulch
Copy link
Contributor Author

No worries, I only submitted this because you were so quick and thorough at reviewing previous cleanup PRs. I wasn't aware there had been regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants