-
Notifications
You must be signed in to change notification settings - Fork 346
Adds required metadata files for flatpak publishing #2085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| </screenshot> | ||
| </screenshots> | ||
| <content_rating type="oars-1.1" /> | ||
| <releases> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that this attribute needs to be changed manually for each version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flathub team expects that but I was thinking of making it autofill this during a GitHub workflow on the flatpak repo.
How does this project do releases? I don't want this addition to make it more difficult.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sourcegit/.github/workflows/ci.yml
Lines 13 to 23 in 080c446
| version: | |
| name: Prepare version string | |
| runs-on: ubuntu-latest | |
| outputs: | |
| version: ${{ steps.version.outputs.version }} | |
| steps: | |
| - name: Checkout sources | |
| uses: actions/checkout@v4 | |
| - name: Output version string | |
| id: version | |
| run: echo "version=$(cat VERSION)" >> "$GITHUB_OUTPUT" |
current version string will be load from
VERSION file and set into environment.
sourcegit/.github/workflows/release.yml
Lines 2 to 5 in 080c446
| on: | |
| push: | |
| tags: | |
| - v* |
release ci will be triggered when HEAD has a tag.
I have seen attempts of publishing SourceGit to Flathub (flathub/flathub#7541).
And the author has not created any PR in SourceGit to solve the issues.
Flathub requires the metadata files to be upstream.
I will be creating a PR in Flathub with a Flatpak manifest that is building from source which requires this to be merged.