-
Notifications
You must be signed in to change notification settings - Fork 346
feature: Move cache to its own directory to follow XDG standards. #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
This app supports |
|
Moreover, I believe that doing so will bring another benefit: when we want to delete |
Portable mode should still be supported is there anything I missed? |
Correct. When running on Mac or Windows everything is in a single directory. But on Linux it is two folders. The cache does not belong next to configuration files. |
…OME/SourceGit` on Linux (#2088) Old datas will be migrated automatically Signed-off-by: leo <longshuang@msn.cn>
…OME/SourceGit` on Linux (#2088) Old datas will be migrated automatically Signed-off-by: leo <longshuang@msn.cn>
|
I've pushed a commit that moves data from |
What else does source git store? It should be in .config if it's only configuration |
|
The files generated by |
On Windows? Correct But on Linux config files are in .config/appname |
|
I saw your commits you did that was basically what this PR is doing. But you are hardcoding the values of XDG dirs. They are env vars. Not static values. |
Cache should not be in the same directory as the configuration. It mostly only applies to linux.
See here for what each folder maps to https://xdg-net.github.io/Xdg.Directories/docs/defaults.html