Add priorityClassName test coverage for cadvisor (PLAT-483)#846
Closed
Chickensoupwithrice wants to merge 1 commit intomainfrom
Closed
Add priorityClassName test coverage for cadvisor (PLAT-483)#846Chickensoupwithrice wants to merge 1 commit intomainfrom
Chickensoupwithrice wants to merge 1 commit intomainfrom
Conversation
The cadvisor DaemonSet template already supports priorityClassName via the shared sourcegraph.priorityClassName helper, but had no test coverage. Add a test case to verify priorityClassName can be set on cadvisor, consistent with the existing tests for gitserver, indexedSearch, searcher, redisCache, and redisStore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
priorityClassNameon the cadvisor DaemonSet, which already supports it via the sharedsourcegraph.priorityClassNamehelper but had no test case.Test plan
helm unittest— all 89 tests pass, including the new cadvisor priority class test.