Skip to content

security: validate batch spec mount name #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbrnrd wants to merge 2 commits into
base: main
Choose a base branch
from
+29 −4
Open

security: validate batch spec mount name #1284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fc583c
security: validate batch spec mount name
cbrnrd Apr 2, 2026
9becc27
Reject other characters
cbrnrd Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions internal/batches/service/service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,26 @@ changesetTemplate:
`,
expectedErr: errors.New("handling mount: step 1 mount path is not in the same directory or subdirectory as the batch spec"),
},
{
name: "files target path with comma",
batchSpecDir: tempDir,
rawSpec: `
name: test-spec
description: A test spec
steps:
- run: echo "hello"
container: alpine:3
files:
"/tmp/x,source=/var/run/docker.sock,target=/var/run/docker.sock": "IGNORED"
changesetTemplate:
title: Test Files
body: Test files target path with comma
branch: test
commit:
message: Test
`,
expectedErr: errors.New("parsing batch spec: step 1 files target path contains invalid characters"),
},
{
name: "mount path dot-dot traversal",
batchSpecDir: tempDir,
Expand Down
13 changes: 9 additions & 4 deletions lib/batches/batch_spec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,19 +169,24 @@ func parseBatchSpec(schema string, data []byte) (*BatchSpec, error) {

for i, step := range spec.Steps {
for _, mount := range step.Mount {
if strings.Contains(mount.Path, invalidMountCharacters) {
if strings.ContainsAny(mount.Path, invalidMountCharacters) {
errs = errors.Append(errs, NewValidationError(errors.Newf("step %d mount path contains invalid characters", i+1)))
}
if strings.Contains(mount.Mountpoint, invalidMountCharacters) {
if strings.ContainsAny(mount.Mountpoint, invalidMountCharacters) {
errs = errors.Append(errs, NewValidationError(errors.Newf("step %d mount mountpoint contains invalid characters", i+1)))
}
}
for name := range step.Files {
if strings.ContainsAny(name, invalidMountCharacters) {
errs = errors.Append(errs, NewValidationError(errors.Newf("step %d files target path contains invalid characters", i+1)))
}
}
}

return &spec, errs
}

const invalidMountCharacters = ","
// docker uses Golang's `encoding/csv` library to parse arguments passed to `--mount`
const invalidMountCharacters = ",\"\n\r"

func (on *OnQueryOrRepository) String() string {
if on.RepositoriesMatchingQuery != "" {
Expand Down
Loading