Fix build by not running test cases#1
Open
basetunnel wants to merge 4 commits intospacekitteh:masterfrom
Open
Conversation
…e not run anymore. The tests were written with an old version (<2.0) of QuickCheck (which requires base <4)
Author
|
So it turns out that since cabal-1.24, you have to define a custom-build stanza in the .cabal file (which is not completely obvious: haskell/cabal#5278). Adding such a stanza also fixes it, but gives the following warning: And indeed, using the most recent cabal, the runTests hook is ignored (and even if it wasn't, it would probably fail similarly to the quickcheck error from https://travis-ci.org/spacekitteh/permutation/jobs/47721007) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the build by changing build-type to Simple, meaning that the tests are not run anymore. The tests were written with an old version (<2.0) of QuickCheck (which requires base <4) and could therefore not compile.