first naive implementation of virtual table#115
first naive implementation of virtual table#115duhlin wants to merge 10 commits intosparklemotion:mainfrom
Conversation
duhlin
commented
Dec 6, 2013
duhlin
commented
- see test/test_vtable.rb for example
- only select is supported (update/insert is not yet implemented)
ext/sqlite3/module.c
Outdated
There was a problem hiding this comment.
I'm not sure about this TRACE implementation. Seems to be a debugging leftover when you created this? There is no other parts of the codebase that use this, so I think might need to be removed.
There was a problem hiding this comment.
You're right. This macro was for debugging only. It can be safely removed.
Le 6 déc. 2013 17:21, "Luis Lavena" notifications@github.com a écrit :
In ext/sqlite3/module.c:
@@ -0,0 +1,244 @@
+#include <stdio.h>
+#include <sqlite3_ruby.h>
+
+#undef ENABLE_TRACE
+
+#ifdef ENABLE_TRACE
+static FILE* pf;
+# define TRACE(str) \I'm not sure about this TRACE implementation. Seems to be a debugging
leftover when you created this? There is no other parts of the codebase
that use this, so I think might need to be removed.—
Reply to this email directly or view it on GitHubhttps://github.com//pull/115/files#r8165201
.
|
Hello, @luislavena Is there anything you'd like me to fix/change/review so that this pull request can be integrated ? May be some documentation ? Regards, Lionel |
* see test/test_vtable.rb for example * only select is supported (update/insert is not yet implemented)
- fix unit test so that it can be launched using 'rake'
…t for better error messages
* remove class SQLite3::Module and create class SQLite3::VTable * when declared, store VTables in db.vtables
|
is there a chance to merge vtable feature into sqlite3 gem? |
5 participants
