Skip to content

feat: Add super-admin role protection for admin hub APIs [SPRW-3087] #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LordNayan merged 1 commit into from
Mar 16, 2026
Merged

feat: Add super-admin role protection for admin hub APIs [SPRW-3087] #955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/modules/billing/services/stripe-subscription.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,21 @@ export class StripeSubscriptionService {
),
};

await this.updateTeamPlanWithBilling(metadata.hubId, plan, billingDetails);
// Get current team plan
const existingTeam = await this.stripeSubscriptionRepo.findTeamById(
metadata.hubId,
);

// Skip webhook overwrite ONLY if admin changed plan recently
if (existingTeam?.billing?.updatedBy === BillingSource.API_CALL) {
console.log("Skipping webhook overwrite due to admin plan change");
} else {
await this.updateTeamPlanWithBilling(
metadata.hubId,
plan,
billingDetails,
);
}
if (!isDowngrading) {
const teamIdObject = new ObjectId(metadata.hubId);
const updateTeam =
Expand Down
5 changes: 3 additions & 2 deletions src/modules/user-admin/controllers/user-admin.hubs.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ export class AdminHubsController {
}

@UseGuards(JwtAuthGuard, RolesGuard)
// @Roles("admin")
@Roles("super-admin")
@ApiBearerAuth()
@ApiOperation({ summary: "Extend trial period for a hub" })
@ApiParam({
Expand Down Expand Up @@ -427,7 +427,7 @@ export class AdminHubsController {
}

@UseGuards(JwtAuthGuard, RolesGuard)
// @Roles("admin")
@Roles("super-admin")
@ApiBearerAuth()
@ApiOperation({ summary: "Add a subscription plan to a hub" })
@ApiParam({
Expand Down Expand Up @@ -468,6 +468,7 @@ export class AdminHubsController {
}

@UseGuards(JwtAuthGuard, RolesGuard)
@Roles("super-admin")
@ApiBearerAuth()
@ApiOperation({ summary: "Change hub subscription plan (upgrade/downgrade)" })
@ApiParam({
Expand Down
2 changes: 2 additions & 0 deletions src/modules/user-admin/services/user-admin.hubs.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,6 +669,7 @@ export class AdminHubsService {

const subscriptionId = stripeProvider?.subscriptionId;

// Update Stripe subscription if exists
if (subscriptionId && !subscriptionId.startsWith("sub_test")) {
await this.stripeSubscriptionService["stripeService"].updateSubscription(
subscriptionId,
Expand All @@ -679,6 +680,7 @@ export class AdminHubsService {
changeType,
proratedAmount,
effectiveDate,
updatedByAdmin: true,
},
);
}
Expand Down
Loading