Merged
Conversation
Because the nette/tester version that supports PHP 8.5 doesn't support 7.4, and test with --prefer-lowest would fail with anything else than nette/tester with 8.5 support.
There was a problem hiding this comment.
Pull request overview
This PR drops support for PHP 7.4 to enable compatibility with nette/tester versions that support PHP 8.5, ensuring the test suite can run successfully with --prefer-lowest dependency resolution.
- Updated minimum PHP version requirement from
^7.4 || ^8.0to^8.0 - Removed PHP 7.4 from the CI test matrix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| composer.json | Updated PHP version constraint to require PHP 8.0 or higher, removing PHP 7.4 support |
| .github/workflows/php.yml | Removed PHP 7.4 from the CI test matrix, maintaining testing for PHP 8.0-8.4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the nette/tester version that supports PHP 8.5 doesn't support 7.4, and test with
--prefer-lowestwould fail with anything else than nette/tester with 8.5 support. Tests on 8.5 added in #19.