Skip to content

feat: drop batch message support from MCP implementation#1969

Closed
simplesagar wants to merge 4 commits intomainfrom
sagar/age-1584-feat-drop-batch-messages-from-the-mcp-implementation
Closed

feat: drop batch message support from MCP implementation#1969
simplesagar wants to merge 4 commits intomainfrom
sagar/age-1584-feat-drop-batch-messages-from-the-mcp-implementation

Conversation

@simplesagar
Copy link
Copy Markdown
Member

@simplesagar simplesagar commented Mar 24, 2026

Summary

  • Remove batchedRawRequest type and its custom UnmarshalJSON from rpc.go
  • Replace handleBatch method with direct handleRequest calls in ServePublic and ServeAuthenticated, preserving error-to-body marshaling semantics (200 OK with JSON-RPC error body)
  • Remove batch-specific tests and convert all test payloads from array-wrapped to single objects across 4 test files

Test Plan

  • mise build:server passes
  • go vet ./internal/mcp/... passes
  • No remaining references to batchedRawRequest or handleBatch
  • CI test suite passes (requires Docker for testcontainers)

Refs: AGE-1584

🤖 Generated with Claude Code


Open with Devin

Batch messages were removed from the MCP spec. This simplifies
request handling to always expect a single JSON-RPC request object
instead of optionally accepting arrays of requests.

Refs: AGE-1584

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@linear
Copy link
Copy Markdown

linear Bot commented Mar 24, 2026

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
gram-docs-redirect Ready Ready Preview, Comment Mar 25, 2026 2:10pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 24, 2026

🦋 Changeset detected

Latest commit: f328d25

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@simplesagar simplesagar marked this pull request as ready for review March 25, 2026 14:08
@simplesagar simplesagar requested a review from a team as a code owner March 25, 2026 14:08
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment thread server/internal/mcp/impl.go
@simplesagar
Copy link
Copy Markdown
Member Author

Re: Devin's batch breaking change flag — this is intentional. The MCP spec removed batch message support. Our MCP clients (Claude, Cursor, etc.) all send single JSON-RPC requests already, so no migration needed on the caller side.

@simplesagar simplesagar marked this pull request as draft March 31, 2026 20:54
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 31, 2026

Deployment failed with the following error:

Invalid request: `attribution.gitUser` should NOT have additional property `isBot`.

@simplesagar simplesagar closed this Apr 8, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant