feat: basic support for enterprise trials#1989
Conversation
🦋 Changeset detectedLatest commit: 065a363 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
Devin Review found 3 new potential issues.
🐛 1 issue in files not directly in the diff
🐛 EnterpriseGate does not recognize enterprise_free_trial tier, blocking trial users from enterprise features (client/dashboard/src/components/enterprise-gate.tsx:21-23)
The EnterpriseGate component at client/dashboard/src/components/enterprise-gate.tsx:21 only checks productTier === "enterprise" to allow access. However, users on the new free trial have productTier set to "enterprise_free_trial" (from client/dashboard/src/hooks/useProductTier.ts:19-20). Since "enterprise_free_trial" !== "enterprise", trial users are blocked from enterprise-gated features (Slack App integration at pages/slackapp/SlackApp.tsx:291 and Hooks at pages/hooks/Hooks.tsx:598). This defeats the core purpose of the enterprise trial, showing trial users a "This feature is available on the Enterprise plan" lock screen instead of giving them access.
View 6 additional findings in Devin Review.
| if orgMetadata.FreeTrialEndsAt.Valid && orgMetadata.FreeTrialEndsAt.Time.After(time.Now().UTC()) { | ||
| org.GramAccountType = "enterprise" | ||
| org.IsFreeTrial = true | ||
| org.FreeTrialEndsAt = org.FreeTrialEndsAt |
There was a problem hiding this comment.
🟡 Self-assignment org.FreeTrialEndsAt = org.FreeTrialEndsAt is a no-op copy-paste error
In the free trial branch at server/internal/mv/organization.go:48, org.FreeTrialEndsAt = org.FreeTrialEndsAt is a self-assignment that does nothing. Looking at the enterprise branch above (line 40: org.FreeTrialEndsAt = orgMetadata.FreeTrialEndsAt.Time), this was clearly meant to be org.FreeTrialEndsAt = orgMetadata.FreeTrialEndsAt.Time. The code is currently correct because org.FreeTrialEndsAt was already initialized to orgMetadata.FreeTrialEndsAt.Time on line 33, but this copy-paste error could become a real bug if the initialization logic changes.
| org.FreeTrialEndsAt = org.FreeTrialEndsAt | |
| org.FreeTrialEndsAt = orgMetadata.FreeTrialEndsAt.Time |
Was this helpful? React with 👍 or 👎 to provide feedback.
| if orgMetadata.FreeTrialEndsAt.Valid && orgMetadata.FreeTrialEndsAt.Time.After(time.Now().UTC()) { | ||
| org.GramAccountType = "enterprise" | ||
| org.IsFreeTrial = true | ||
| org.FreeTrialEndsAt = org.FreeTrialEndsAt | ||
| return &org, nil |
There was a problem hiding this comment.
🚩 Free trial users have HasActiveSubscription=false, which may incorrectly limit MCP server enabling
The free trial branch in DescribeOrganization (server/internal/mv/organization.go:44-51) sets GramAccountType to "enterprise" and IsFreeTrial to true, but does NOT set HasActiveSubscription to true. It remains at the default false from line 31.
This matters because server/internal/toolsets/impl.go:351 uses isUnpaidAccount := !authCtx.HasActiveSubscription to limit the number of enabled MCP servers. Free trial users (who are supposed to have enterprise access) would be subject to the unpaid account MCP server limit.
If the intent is that free trial = full enterprise access, then HasActiveSubscription should be set to true in the free trial branch. If free trial users are intentionally limited, this is fine but inconsistent with setting their account type to "enterprise".
Was this helpful? React with 👍 or 👎 to provide feedback.
|
@chase-crumbaugh have you got screenshots of the other bits of UI (e.g expired?) |
simplesagar
left a comment
simplesagar
left a comment
There was a problem hiding this comment.
Looks great - lets use https://www.speakeasy.com/book-demo as the primary link for booking time for enterprise upgrades. We should probably add that link to the pop up on left nav bar showing time left in trial as a clear CTA
3 participants
Uh oh!
There was an error while loading. Please reload this page.