fix(core/algorithms): replace hardcoded Assert URL with data-cite mechanism#5090
Merged
marcoscaceres merged 9 commits intomainfrom Apr 15, 2026
Merged
fix(core/algorithms): replace hardcoded Assert URL with data-cite mechanism#5090marcoscaceres merged 9 commits intomainfrom
marcoscaceres merged 9 commits intomainfrom
Conversation
✅ Deploy Preview for respec-pr ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Moved algorithms.js to run before inlines.js in all profiles - Updated algorithms.js to use data-cite="INFRA#assert" for linking - Updated tests to include localBiblio for INFRA spec Co-authored-by: marcoscaceres <870154+marcoscaceres@users.noreply.github.com>
Contributor
marcoscaceres
left a comment
marcoscaceres
left a comment
There was a problem hiding this comment.
@copilot, exclude the builds/ in the commit. No need for those.
marcoscaceres
requested changes
Nov 26, 2025
Contributor
marcoscaceres
left a comment
marcoscaceres
left a comment
There was a problem hiding this comment.
@copilot some suggestions for you.
Copilot
AI
changed the title
[WIP] Fix hard coded Assert URL in algorithm.js
Replace hardcoded Assert URL with data-cite mechanism
Nov 26, 2025
- Replace explicit anchor with [=Assert=] syntax for ReSpec linking - Add data-cite="INFRA" to li element if not already citing infra - Revert test file and builds folder to original state Co-authored-by: marcoscaceres <870154+marcoscaceres@users.noreply.github.com>
Contributor
Author
Excluded builds/ from the commit by reverting them to the original state (commit 0be2a94). Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
marcoscaceres
approved these changes
Mar 27, 2026
sidvishnoi
reviewed
Mar 30, 2026
The [=Assert=] approach required xref to be enabled, causing linking errors for non-W3C specs with xref disabled. Using data-cite="INFRA#assert" on the anchor directly allows data-cite.js to resolve it regardless of whether xref is enabled. Also add localBiblio for INFRA in the test so it can resolve without network access. Agent-Logs-Url: https://github.com/speced/respec/sessions/fb89ccbf-6f93-4756-83c5-232074218650 Co-authored-by: marcoscaceres <870154+marcoscaceres@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
marcoscaceres
approved these changes
Apr 12, 2026
marcoscaceres
changed the title
marcoscaceres
changed the title
marcoscaceres
changed the title
marcoscaceres
approved these changes
Apr 12, 2026
sidvishnoi
changed the title
sidvishnoi
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
algorithms.jshardcoded the Assert link URL tohttps://infra.spec.whatwg.org/#assertinstead of using ReSpec's standarddata-citelinking mechanism.Changes
src/core/algorithms.js: Usedata-cite="INFRA#assert"directly on the anchor element instead of the hardcoded URL. This approach works viadata-cite.jsregardless of whetherxrefis enabled, ensuring compatibility with non-W3C profiles wherexrefmay be disabled.algorithms.jsbeforedata-cite.jsin all profiles (aom, dini, geonovum, w3c) so the anchor is created beforedata-cite.jsprocesses it.localBibliofor INFRA spec to enable offline test resolution.Before
After
The anchor is now resolved through ReSpec's
data-cite.jsbibliography system, which works for all profiles regardless of whetherxrefis enabled.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.