fix(data-include): clean up data-oninclude attribute after processing#5175
Open
marcoscaceres wants to merge 2 commits intomainfrom
Open
fix(data-include): clean up data-oninclude attribute after processing#5175marcoscaceres wants to merge 2 commits intomainfrom
marcoscaceres wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes attribute cleanup in the core/data-include module by removing the correct include hook attribute (data-oninclude) after processing, aligning behavior with documented usage and eliminating leftover DOM attributes.
Changes:
- Update
removeIncludeAttributes()to removedata-oninclude(instead of the non-existentonincludeattribute).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
67
to
74
| function removeIncludeAttributes(el) { | ||
| [ | ||
| "data-include", | ||
| "data-include-format", | ||
| "data-include-replace", | ||
| "data-include-id", | ||
| "oninclude", | ||
| "data-oninclude", | ||
| ].forEach(attr => el.removeAttribute(attr)); |
There was a problem hiding this comment.
Consider adding/adjusting a unit test to assert that data-oninclude is removed after processing (similar to the existing assertions for data-include and data-include-format). This prevents regressions where the attribute is left behind again.
Contributor
Author
There was a problem hiding this comment.
agree, this needs a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
removeIncludeAttributesfunction removedoninclude(without thedata-prefix), which doesn't match the actual HTML attributedata-oninclude. The attribute was never cleaned up.Closes #5072