fix(caniuse): add role=img to browser support cells for valid HTML#5176
Open
marcoscaceres wants to merge 2 commits intomainfrom
Open
fix(caniuse): add role=img to browser support cells for valid HTML#5176marcoscaceres wants to merge 2 commits intomainfrom
marcoscaceres wants to merge 2 commits intomainfrom
Conversation
The div has aria-label with the full description, so children are presentational. Set inner img alt to empty to avoid double-announcement.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes HTML validity for the “Can I Use” browser support cells by ensuring elements with aria-label have an appropriate ARIA role, aligning generated output with Nu validator requirements (per #5091).
Changes:
- Add
role="img"to caniuse browser support cell containers that usearia-label. - Make the nested browser logo
<img>decorative by settingalt=""to avoid double announcements.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The div elements with aria-label lacked a role attribute, violating HTML spec per the Nu validator. Added role=img since the aria-label fully describes the visual content. Set inner img alt to empty to avoid double-announcement.
Closes #5091