fix(render-biblio): sanitize spaces in reference IDs#5177
Open
marcoscaceres wants to merge 3 commits intomainfrom
Open
fix(render-biblio): sanitize spaces in reference IDs#5177marcoscaceres wants to merge 3 commits intomainfrom
marcoscaceres wants to merge 3 commits intomainfrom
Conversation
Reference names with spaces (e.g. 'Ruby TTS Req') produced invalid HTML IDs containing spaces. Consolidates all bib- ID generation through a bibRefId() helper that replaces whitespace with hyphens.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes invalid HTML id generation for bibliography entries when reference keys contain whitespace by centralizing bib fragment/id creation in a helper that replaces whitespace with hyphens.
Changes:
- Add
bibRefId(ref)helper to generatebib-...IDs with whitespace normalized to-. - Update inline citation rendering to link to
#${bibRefId(key)}. - Update reference list rendering and alias/warn selectors to use the same normalized bib IDs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Hmmm... definitely need a test for this one. The examples are wild: As I never expected ids from bib-ref to be used this way (they follow the short name rules from w3c)... but sure, why not! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference names with spaces (e.g. 'Ruby TTS Req') produced invalid HTML IDs containing spaces. Consolidates all bib- ID generation through a bibRefId() helper that replaces whitespace with hyphens.
Closes #5102