fix(sotd): remove array wrapper on wgPatentURI in patent disclosure link#5180
fix(sotd): remove array wrapper on wgPatentURI in patent disclosure link#5180marcoscaceres wants to merge 3 commits intomainfrom
Conversation
The template had href=${[wgPatentURI]} which wraps the URI in a JS
array. When wgPatentURI is undefined, array-to-string coercion
produces an empty string, creating a self-referencing <a href="">.
Remove the array wrapper so the URI is used directly.
Closes #2638
There was a problem hiding this comment.
Pull request overview
This PR fixes the W3C SOTD “patent disclosures” link rendering by removing an unintended array wrapper around wgPatentURI, which could coerce undefined to an empty string and produce a self-referencing <a href=""> link.
Changes:
- Update the SOTD deliverer template to use
wgPatentURIdirectly in the patent disclosure linkhref.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot, does it even make sense put print the patent link if there's no conf.wgPatentURI? |
Agent-Logs-Url: https://github.com/speced/respec/sessions/08fce312-6f95-42be-868e-3696b6a47ff5 Co-authored-by: marcoscaceres <870154+marcoscaceres@users.noreply.github.com>
No, it doesn't make sense to show the link without a URI. Fixed in f86db0a — when |
The template had href=${[wgPatentURI]} which wraps the URI in a JS array. When wgPatentURI is undefined, array-to-string coercion produces an empty string, creating a self-referencing . Removed the array wrapper.
Closes #2638