fix(render-biblio): handle authors as string instead of array#5183
Open
marcoscaceres wants to merge 3 commits intomainfrom
Open
fix(render-biblio): handle authors as string instead of array#5183marcoscaceres wants to merge 3 commits intomainfrom
marcoscaceres wants to merge 3 commits intomainfrom
Conversation
When localBiblio has authors as a string instead of an array, the join() call crashes and the entire reference section fails to render. Now shows an error with a helpful hint, and auto-corrects to an array so rendering continues. Closes #4237
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a crash in core/render-biblio when localBiblio entries mistakenly provide authors as a string (instead of an array), by reporting an error and coercing the value so references can continue rendering.
Changes:
- Detect non-array
ref.authors, report an error with a hint, and coerce it to an array. - Continue rendering the bibliography instead of failing on
.join().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When localBiblio has authors as a string instead of an array, the join() call crashes and the entire reference section fails to render. Now shows an error with a helpful hint, and auto-corrects to an array so rendering continues.
Closes #4237